Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peer_connection: Implement state changes after spec and fix race #598

Merged
merged 3 commits into from
Aug 2, 2024
Merged

peer_connection: Implement state changes after spec and fix race #598

merged 3 commits into from
Aug 2, 2024

Commits on Aug 2, 2024

  1. peer_connection: Implement state changes after spec 

    https://www.w3.org/TR/webrtc/#rtcpeerconnectionstate-enum

Ported from PION
pion/webrtc#2435
    @haaspors
    haaspors committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    f599514 View commit details
    Browse the repository at this point in the history

  2. peer_connection: Fix state transition race 

    DTLS transport state was previously acquired and sent over to the async
context returned. This would in some rare cases obviously lead to
updating peer connection state with an old DTLS transport state.
This would in turn lead to PeerConnection not updating it's state
correctly. Sometimes we would see PeerConnection never reaching Connected.
    @haaspors
    haaspors committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    fcdef6f View commit details
    Browse the repository at this point in the history

  3. peer_connection: Initialize PeerConnectionInternal correctly 

    PeerConnectionInternal was initialized with default transports and then
mutated right after. This resulted in create_ice_transport() using the
default DTLS transport instance which again led to state transition
reading DTLS transport state from the wrong instance.
    @haaspors
    haaspors committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    974e9ec View commit details
    Browse the repository at this point in the history