Fix peerconnetcion connecting state #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2435 +/- ##
==========================================
- Coverage 77.70% 77.63% -0.08%
==========================================
Files 87 87
Lines 9298 9300 +2
==========================================
- Hits 7225 7220 -5
- Misses 1644 1649 +5
- Partials 429 431 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sean-Der
approved these changes
Mar 3, 2023
|
A unit test for but approval from me! If you don't think a test is needed that is totally fine |
cnderrauber
force-pushed
the
pc_connecting
branch
2 times, most recently
from
0002603
to
c0a7f15
Compare
Make updateConnectionState consistent with https://www.w3.org/TR/webrtc/#rtcpeerconnectionstate-enum
cnderrauber
force-pushed
the
pc_connecting
branch
from
c0a7f15
to
b7c9b8c
Compare
haaspors
added a commit
to haaspors/webrtc
that referenced
this pull request
Aug 2, 2024
haaspors
added a commit
to haaspors/webrtc
that referenced
this pull request
Aug 2, 2024
rainliu
pushed a commit
to webrtc-rs/webrtc
that referenced
this pull request
Aug 2, 2024
* peer_connection: Implement state changes after spec https://www.w3.org/TR/webrtc/#rtcpeerconnectionstate-enum Ported from PION pion/webrtc#2435 * peer_connection: Fix state transition race DTLS transport state was previously acquired and sent over to the async context returned. This would in some rare cases obviously lead to updating peer connection state with an old DTLS transport state. This would in turn lead to PeerConnection not updating it's state correctly. Sometimes we would see PeerConnection never reaching Connected. * peer_connection: Initialize PeerConnectionInternal correctly PeerConnectionInternal was initialized with default transports and then mutated right after. This resulted in create_ice_transport() using the default DTLS transport instance which again led to state transition reading DTLS transport state from the wrong instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The peerconnection state should transit to connecting if icestate is checking or dtls connecting
Description
Reference issue
Fixes #...