docs: update README and examples #2848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylemkimon
requested review from
alexander-akait,
hiroppy and
knagaitsev
as code owners
Codecov Report
@@ Coverage Diff @@
## v4 #2848 +/- ##
=======================================
Coverage 93.02% 93.02%
=======================================
Files 39 39
Lines 1305 1305
Branches 355 355
=======================================
Hits 1214 1214
Misses 87 87
Partials 4 4 Continue to review full report at Codecov.
|
snitin315
reviewed
Nov 20, 2020
| `webpack.config.js` is, run: | ||
|
|
||
| ```console | ||
| node_modules/.bin/webpack-dev-server | ||
| node_modules/.bin/webpack serve |
There was a problem hiding this comment.
npx could use the globally installed module, which would lead to errors. I think this was to demonstrate that one should use the local module. Binaries can be installed in other locations than node_modules/.bin, but those who do that would be advanced users.
alexander-akait
approved these changes
Nov 20, 2020
|
Thanks |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
Updated README and examples for v4.
Closes #2799, closes #2813, and closes #2814.
Breaking Changes
N/A
Additional Info
I have not checked these examples work and demonstrate as intended.