Skip to content

Usage With NPM Scripts modify "serve": "webpack serve" / Update README.md #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

blackraccoon000
Copy link

Beginners get confused by the guide when using webpack-dev-sercer.
This change can reduce the burden on the answer.

webpack/webpack-cli#1948
#2029 (comment)

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

I looked at the docs and set it up, but when I changed it by looking at the link below, it worked.
I think the documentation should be changed.

#2029 (comment)

Breaking Changes

Additional Info

Beginners get confused by the guide when using webpack-dev-sercer.
This change can reduce the burden on the answer.

webpack/webpack-cli#1948
webpack#2029 (comment)
@jsf-clabot
Copy link

jsf-clabot commented Nov 6, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #2814 (e9ae75d) into master (4ab1f21) will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2814      +/-   ##
==========================================
- Coverage   93.77%   93.54%   -0.23%     
==========================================
  Files          34       34              
  Lines        1333     1333              
  Branches      381      381              
==========================================
- Hits         1250     1247       -3     
- Misses         81       84       +3     
  Partials        2        2              
Impacted Files Coverage Δ
lib/utils/updateCompiler.js 97.14% <0.00%> (-2.86%) ⬇️
lib/Server.js 96.36% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab1f21...e9ae75d. Read the comment docs.

@anshumanv anshumanv mentioned this pull request Nov 6, 2020
6 tasks
@ylemkimon ylemkimon mentioned this pull request Nov 20, 2020
6 tasks
@alexander-akait
Copy link
Member

Thanks for the PR, fixed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants