fix: don't override package.json properties (#4017)

packages/generators/src/handlers/default.ts

@@ -176,11 +176,22 @@ export async function questions(
  * @param self Generator values
  */
 export function generate(self: CustomGenerator): void {
-  self.fs.extendJSON(
-    self.destinationPath("package.json"),
-    // eslint-disable-next-line @typescript-eslint/no-var-requires
-    require(resolveFile("package.json.js"))(self.answers.devServer),
-  );
+  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  const destPkgJson = require(resolveFile("package.json.js"))(self.answers.devServer);
+  const sourcePkgJsonPath = self.destinationPath("package.json");
+  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  const sourcePkgJson = require(sourcePkgJsonPath);
+  // Make sure that we do not override set metadata
+  if (sourcePkgJson.name) {
+    delete destPkgJson.name;
+  }
+  if (sourcePkgJson.description) {
+    delete destPkgJson.description;
+  }
+  if (sourcePkgJson.version) {
+    delete destPkgJson.version;
+  }
+  self.fs.extendJSON(sourcePkgJsonPath, destPkgJson);
 
   // Generate entry file
   let entry = "./src/index.";

test/utils/test-utils.test.js

@@ -75,11 +75,24 @@ describe("runAndGetWatchProc function", () => {
 
   it("writes to stdin", async () => {
     const assetsPath = await uniqueDirectoryForTest();
-    const { stdout } = await runAndGetProcess(assetsPath, ["init", "--force", "--template=mango"], {
+    const proc = runAndGetProcess(assetsPath, ["init", "--force", "--template=mango"], {
       input: ENTER,
+      timeout: 60000,
     });
 
-    expect(stdout).toContain("Project has been initialised with webpack!");
+    let found = false;
+
+    await new Promise((resolve) => {
+      proc.stdout.on("data", (data) => {
+        if (data.includes("Project has been initialised with webpack!")) {
+          found = true;
+
+          resolve();
+        }
+      });
+    });
+
+    expect(found).toBe(true);
   });
 });