-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dont override set pkg.json props #4017
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4017 +/- ##
===========================================
- Coverage 90.89% 73.70% -17.20%
===========================================
Files 22 21 -1
Lines 1692 1696 +4
Branches 488 490 +2
===========================================
- Hits 1538 1250 -288
- Misses 154 446 +292
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evenstensberg Can you fix CI?
@evenstensberg Can you rebase? I think it is already fixed in our master/main |
6b2eabf
to
93d8d9a
Compare
@evenstensberg Thanks for your update. I labeled the Pull Request so reviewers will review it again. @alexander-akait Please review the new changes. |
c12ebf3
to
1155dcb
Compare
Signed-off-by: Even Stensberg <evenstensberg@gmail.com>
1155dcb
to
f44d1c9
Compare
I want to merge it as is, because it works locally without any problems and restore our CI with bumping some deps in other PR |
What kind of change does this PR introduce?
Fixes #3754
Did you add tests for your changes?
No
If relevant, did you update the documentation?
N/A
Summary
Doesnt override already set values in pkg.json
Does this PR introduce a breaking change?
No
Other information
Might need to fix/add test for this.