Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont override set pkg.json props #4017

Merged
merged 4 commits into from
Jan 19, 2024
Merged

fix: dont override set pkg.json props #4017

merged 4 commits into from
Jan 19, 2024

Conversation

evenstensberg
Copy link
Member

What kind of change does this PR introduce?

Fixes #3754

Did you add tests for your changes?
No

If relevant, did you update the documentation?
N/A
Summary
Doesnt override already set values in pkg.json

Does this PR introduce a breaking change?
No
Other information
Might need to fix/add test for this.

@evenstensberg evenstensberg requested a review from a team as a code owner November 21, 2023 19:59
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (145a10f) 90.89% compared to head (e7797b9) 73.70%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4017       +/-   ##
===========================================
- Coverage   90.89%   73.70%   -17.20%     
===========================================
  Files          22       21        -1     
  Lines        1692     1696        +4     
  Branches      488      490        +2     
===========================================
- Hits         1538     1250      -288     
- Misses        154      446      +292     
Files Coverage Δ
packages/generators/src/handlers/default.ts 5.55% <0.00%> (-93.21%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 145a10f...e7797b9. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evenstensberg Can you fix CI?

@alexander-akait
Copy link
Member

@evenstensberg Can you rebase? I think it is already fixed in our master/main

@webpack-bot
Copy link

@evenstensberg Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@alexander-akait Please review the new changes.

evenstensberg and others added 3 commits January 19, 2024 15:43
Signed-off-by: Even Stensberg <evenstensberg@gmail.com>
@alexander-akait
Copy link
Member

I want to merge it as is, because it works locally without any problems and restore our CI with bumping some deps in other PR

@alexander-akait alexander-akait merged commit 47924bf into master Jan 19, 2024
18 of 56 checks passed
@alexander-akait alexander-akait deleted the fix/override branch January 19, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack-cli init should not overwrite package.json "name", "version" and "description" properties
3 participants