Conversation
BackEndTea
force-pushed
the
enhancement/annotations
branch
from
c56989d to
2c8dcb9
Compare
Collaborator
Author
Contributor
|
I don't mind, but if it's work based on the other patch, it should have my commits in it |
This helps IDEs etc with telling users this method is deprecated
* Add "unicodeLetters" assertion for Unicode letters
This means PHP won't search the current namespace for a function first It also means PHP can use the Opcache (opcode?) for some functions, which is the actual speed increase. If possible i'd use the `use function` syntax, but that became available in php 5.6, and thus isn't an option atm.
BackEndTea
force-pushed
the
enhancement/annotations
branch
from
2c8dcb9 to
6146a27
Compare
added 2 commits
August 9, 2019 14:07
Also fix dulicate classes.
This was referenced Aug 24, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #43
Supersedes #83 & #102
This includes #102, but has removed (or activated) disabled/ not working assert annotations.
The asserts for the
countandcytpebased assertions have also been removed. Forcountdue to the fact that we don't actually assert that the input is countable, and forctypedue to the fact that it can accept integers as valid input.