Add "letters" assertion for Unicode letters#112
Merged
BackEndTea merged 6 commits intowebmozarts:masterfrom Aug 7, 2019
rossbearman:master
Merged
Add "letters" assertion for Unicode letters#112BackEndTea merged 6 commits intowebmozarts:masterfrom rossbearman:master
BackEndTea merged 6 commits intowebmozarts:masterfrom
rossbearman:master
Conversation
BackEndTea
reviewed
Jun 25, 2019
BackEndTea
changed the title
BackEndTea
reviewed
Jun 27, 2019
Collaborator
BackEndTea
left a comment
BackEndTea
left a comment
There was a problem hiding this comment.
👍
Do you also want to take a look @Nyholm ?
Nyholm
reviewed
Jun 27, 2019
Contributor
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
I like the implementation but I’m not 100% sure about the name “letters”. Could we get a more descriptive name? OnlyUnicode?
Contributor
Author
|
I don't think |
Collaborator
|
|
BackEndTea
approved these changes
Aug 7, 2019
Collaborator
BackEndTea
left a comment
BackEndTea
left a comment
There was a problem hiding this comment.
👍
Thank you for your contribution.
I'll merge this as soon as CI is finished
BackEndTea
pushed a commit
that referenced
this pull request
Aug 9, 2019
* Add "unicodeLetters" assertion for Unicode letters
BackEndTea
pushed a commit
that referenced
this pull request
Aug 9, 2019
* Add "unicodeLetters" assertion for Unicode letters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for validating against the Unicode letter class.
Tests cover passing assertions for basic Latin characters and an array of different Unicode only alphabets and failing assertions for strings including numbers, the simple alphabet's copyright symbol and a Unicode emoji.
Fixes: #98