Skip to content

change argmin/argmax to take scalar axis#724

Merged
huningxin merged 1 commit into
webmachinelearning:mainfrom
philloooo:main
Jul 18, 2024
Merged

change argmin/argmax to take scalar axis#724
huningxin merged 1 commit into
webmachinelearning:mainfrom
philloooo:main

Conversation

@philloooo

@philloooo philloooo commented Jul 15, 2024 •
edited by pr-preview Bot
Loading

Copy link
Copy Markdown
Contributor

fixes #629

  • Changes argmin/argmax to take scalar axis instead of axes list.
  • Remove default value for axis, so now it becomes positional argument

@fdwr @huningxin please take a look :)

Preview | Diff

philloooo
philloooo commented Jul 15, 2024
View reviewed changes
Comment thread index.bs Outdated
fdwr
fdwr approved these changes Jul 15, 2024
View reviewed changes

@fdwr fdwr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Phillis for the update. FYI to @BruceDai and @Honry since this impacts WPT's and ORT WebNN EP.

Comment thread index.bs Outdated
inexorabletash
inexorabletash reviewed Jul 15, 2024
View reviewed changes
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
inexorabletash
inexorabletash reviewed Jul 16, 2024
View reviewed changes
Comment thread index.bs Outdated
inexorabletash
inexorabletash approved these changes Jul 16, 2024
View reviewed changes

@inexorabletash inexorabletash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fdwr fdwr requested a review from huningxin July 16, 2024 22:38
@fdwr

fdwr commented Jul 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Note forced pushes make it harder to compare iterations in the Files tab 🔍😐, as the "Show changes since your last review" button doesn't work correctly.

huningxin
huningxin approved these changes Jul 18, 2024
View reviewed changes

@huningxin huningxin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huningxin huningxin merged commit 92ff390 into webmachinelearning:main Jul 18, 2024
github-actions Bot added a commit that referenced this pull request Jul 18, 2024
@huningxin @github-actions
Merge pull request #724 from philloooo/main
1ca2f98 
SHA: 92ff390
Reason: push, by huningxin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 22, 2024
@miaobin @chromium-wpt-export-bot
WebNN: Change argMin/argMax to take scalar axis
8b63ee9 
This CL changes argMin/argMax to take scalar axis to align with the spec
change [1].

The changes include the definition of IDL and mojo, the implementation
of DirectML, TfLite and CoreML backend and the related unit tests and
WPT tests.

[1] webmachinelearning/webnn#724

Bug: 352359898
Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jul 22, 2024
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2024
@miaobin @chromium-wpt-export-bot
WebNN: Change argMin/argMax to take scalar axis
9ecbb0f 
This CL changes argMin/argMax to take scalar axis to align with the spec
change [1].

The changes include the definition of IDL and mojo, the implementation
of DirectML, TfLite and CoreML backend and the related unit tests and
WPT tests.

[1] webmachinelearning/webnn#724

Bug: 352359898
Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 23, 2024
@miaobin
WebNN: Change argMin/argMax to take scalar axis
052492e 
This CL changes argMin/argMax to take scalar axis to align with the spec
change [1].

The changes include the definition of IDL and mojo, the implementation
of DirectML, TfLite and CoreML backend and the related unit tests and
WPT tests.

[1] webmachinelearning/webnn#724

Bug: 352359898
Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Commit-Queue: Bin Miao <bin.miao@intel.com>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1331567}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2024
@miaobin @chromium-wpt-export-bot
WebNN: Change argMin/argMax to take scalar axis
6f81f2f 
This CL changes argMin/argMax to take scalar axis to align with the spec
change [1].

The changes include the definition of IDL and mojo, the implementation
of DirectML, TfLite and CoreML backend and the related unit tests and
WPT tests.

[1] webmachinelearning/webnn#724

Bug: 352359898
Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Commit-Queue: Bin Miao <bin.miao@intel.com>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1331567}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2024
@miaobin @chromium-wpt-export-bot
WebNN: Change argMin/argMax to take scalar axis
acd7858 
This CL changes argMin/argMax to take scalar axis to align with the spec
change [1].

The changes include the definition of IDL and mojo, the implementation
of DirectML, TfLite and CoreML backend and the related unit tests and
WPT tests.

[1] webmachinelearning/webnn#724

Bug: 352359898
Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Commit-Queue: Bin Miao <bin.miao@intel.com>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1331567}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 25, 2024
@miaobin @moz-wptsync-bot
Bug 1909288 [wpt PR 47235] - WebNN: Change argMin/argMax to take scal…
7753649 
…ar axis, a=testonly

Automatic update from web-platform-tests
WebNN: Change argMin/argMax to take scalar axis

This CL changes argMin/argMax to take scalar axis to align with the spec
change [1].

The changes include the definition of IDL and mojo, the implementation
of DirectML, TfLite and CoreML backend and the related unit tests and
WPT tests.

[1] webmachinelearning/webnn#724

Bug: 352359898
Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Commit-Queue: Bin Miao <bin.miao@intel.com>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1331567}

--

wpt-commits: acd785862cc0cd8a52e83ac6db95403e0e6e5450
wpt-pr: 47235
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Jul 26, 2024
@miaobin @moz-wptsync-bot
Bug 1909288 [wpt PR 47235] - WebNN: Change argMin/argMax to take scal…
d73d651 
…ar axis, a=testonly

Automatic update from web-platform-tests
WebNN: Change argMin/argMax to take scalar axis

This CL changes argMin/argMax to take scalar axis to align with the spec
change [1].

The changes include the definition of IDL and mojo, the implementation
of DirectML, TfLite and CoreML backend and the related unit tests and
WPT tests.

[1] webmachinelearning/webnn#724

Bug: 352359898
Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Commit-Queue: Bin Miao <bin.miao@intel.com>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1331567}

--

wpt-commits: acd785862cc0cd8a52e83ac6db95403e0e6e5450
wpt-pr: 47235
ChunMinChang pushed a commit to ChunMinChang/gecko-dev that referenced this pull request Jul 26, 2024
@miaobin @ChunMinChang
Bug 1909288 [wpt PR 47235] - WebNN: Change argMin/argMax to take scal…
9f5aae0 
…ar axis, a=testonly

Automatic update from web-platform-tests
WebNN: Change argMin/argMax to take scalar axis

This CL changes argMin/argMax to take scalar axis to align with the spec
change [1].

The changes include the definition of IDL and mojo, the implementation
of DirectML, TfLite and CoreML backend and the related unit tests and
WPT tests.

[1] webmachinelearning/webnn#724

Bug: 352359898
Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Commit-Queue: Bin Miao <bin.miao@intel.com>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1331567}

--

wpt-commits: acd785862cc0cd8a52e83ac6db95403e0e6e5450
wpt-pr: 47235
@BruceDai BruceDai mentioned this pull request Aug 2, 2024
Closed
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
@miaobin @moz-wptsync-bot
Bug 1909288 [wpt PR 47235] - WebNN: Change argMin/argMax to take scal…
bc633e8 
…ar axis, a=testonly

Automatic update from web-platform-tests
WebNN: Change argMin/argMax to take scalar axis

This CL changes argMin/argMax to take scalar axis to align with the spec
change [1].

The changes include the definition of IDL and mojo, the implementation
of DirectML, TfLite and CoreML backend and the related unit tests and
WPT tests.

[1] webmachinelearning/webnn#724

Bug: 352359898
Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Commit-Queue: Bin Miao <bin.miao@intel.com>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1331567}

--

wpt-commits: acd785862cc0cd8a52e83ac6db95403e0e6e5450
wpt-pr: 47235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huningxin huningxin huningxin approved these changes
@fdwr fdwr fdwr approved these changes
+1 more reviewer
@inexorabletash inexorabletash inexorabletash approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

argMax/Min only support scalar axis in TFLite runtime

4 participants

@philloooo @fdwr @inexorabletash @huningxin