WebNN: Change argMin/argMax to take scalar axis#47235
Merged
Merged
Conversation
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5721028
branch
from
8b63ee9 to
9ecbb0f
Compare
This CL changes argMin/argMax to take scalar axis to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML, TfLite and CoreML backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#724 Bug: 352359898 Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Phillis Tang <phillis@chromium.org> Commit-Queue: Bin Miao <bin.miao@intel.com> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1331567}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5721028
branch
from
9ecbb0f to
6f81f2f
Compare
wpt-pr-bot
approved these changes
Jul 23, 2024
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL changes argMin/argMax to take scalar axis to align with the spec
change [1].
The changes include the definition of IDL and mojo, the implementation
of DirectML, TfLite and CoreML backend and the related unit tests and
WPT tests.
[1] webmachinelearning/webnn#724
Bug: 352359898
Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Commit-Queue: Bin Miao <bin.miao@intel.com>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1331567}