fix: resolved language randomly switching when in dev mode #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewHawkins
requested review from
bbrennanbasis,
gosteenBASIS and
hyyan
as code owners
hyyan
requested changes
Oct 27, 2025
There was a problem hiding this comment.
@MatthewHawkins This doesn't really work for me. Also, in theory, that's exactly what the npm start command is already doing.
https://github.com/webforj/webforj-documentation/blob/main/docs/package.json#L7
| apiKey: 'a69d79113b838bfc8490ffb56cef78f2', | ||
| indexName: 'umentation-webforj', | ||
| contextualSearch: true, | ||
| contextualSearch: process.env.NODE_ENV !== 'development', |
There was a problem hiding this comment.
@MatthewHawkins how does this affect anything
| value: '<div class="separator" aria-hidden></div>', | ||
| }, | ||
| { | ||
| ...(process.env.NODE_ENV === 'development' ? [] : [{ |
There was a problem hiding this comment.
@MatthewHawkins Same , why this change ?
|
@hyyan Agreed - but it seemed that the npm command wasn't respecting the single locale, so I tried this fix. It worked for me when I ran the dev server and let it sit for a few hours, but if it doesn't work for you, I'll go back to the drawing board. |
hyyan
added
the
status: waiting-for-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.