fix(bundling): fixed the multiple React instance and useRef errors #355

sreenara · 2025-01-07T17:06:34Z

Added the externals parameter in the webpack.config.js for all the widget packages that use React.
Added react and react-dom to peer-dependencies for our widget packages so that we pass responsibility to samples app to include react
Added @webex/cc-store as externals parameter in the webpack config as it is a shared package and required to be shared as only one copy of instance.

Additional things to test:

Remove alias from webpack config -> Tested this and removed. It's not required
Remove resolutions from package.json of react-samples -> Tested this and removed. It's not required.

coderabbitai · 2025-01-07T17:06:48Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

docs/react-samples/package.json

docs/react-samples/src/App.tsx

docs/react-samples/webpack.config.js

webpack.config.js

docs/react-samples/src/App.tsx

packages/contact-center/station-login/src/station-login/index.tsx

rarajes2 · 2025-01-08T14:51:00Z

packages/contact-center/user-state/src/user-state/index.tsx

@@ -1,6 +1,6 @@
 import React from 'react';
 import store from '@webex/cc-store';
-import {observer} from 'mobx-react';
+import {observer} from 'mobx-react-lite';


changed back to mobx-react.

@rarajes2 @mkesavan13 @Shreyas281299 would it be better to use mobx-react-lite since it's a smaller module than mobx-react? We should try to conserve size wherever possible.

I am in favour of using mobx-react-lite. Let's hear from @mkesavan13 and @Shreyas281299 then we can decide

packages/contact-center/station-login/package.json

mkesavan13

Just a couple of nitpicks. Looks good otherwise

mkesavan13 · 2025-01-08T16:43:33Z

packages/contact-center/cc-widgets/package.json

    "build": "yarn run -T tsc",
-    "build:src": "webpack && yarn run build",
+    "build:src": "webpack",


Should we consider calling clean in individual widgets instead of the global package.json command?

They are at individual package level, we run all of them once with workspaces foreach ... command. Correct me if I misunderstood

Addressed in the PR - #356

mkesavan13 · 2025-01-08T16:44:06Z

packages/contact-center/station-login/src/station-login/index.tsx

+  console.log('StationLogin: Teams >>', teams);
+  console.log('StationLogin: Login Options >>', loginOptions);


Do we need these console statements anymore?

will remove

Addressed in the PR - #356

sreenara · 2025-01-10T06:43:17Z

🎉 This PR is included in version 1.28.0-ccwidgets.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.28.0-ccwidgets.8](webex/widgets@v1.28.0-ccwidgets.7...v1.28.0-ccwidgets.8) (2025-01-10) ### Bug Fixes * **bundling:** fixed the multiple React instance and useRef errors ([webex#355](webex#355)) ([473cd4f](webex@473cd4f)) * cleanup and using mobx-react-lite ([webex#356](webex#356)) ([0b304c4](webex@0b304c4))

sreenara · 2025-02-05T11:42:21Z

🎉 This PR is included in version 1.28.0-ccconnectors.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.28.0-ccconnectors.1](webex/widgets@v1.27.5...v1.28.0-ccconnectors.1) (2025-02-05) ### Bug Fixes * add material to all components ([webex#376](webex#376)) ([de0ca28](webex@de0ca28)) * **bundling:** fixed the multiple React instance and useRef errors ([webex#355](webex#355)) ([473cd4f](webex@473cd4f)) * **call-control:** add-call-control-widget ([webex#362](webex#362)) ([a677f5e](webex@a677f5e)) * **cc-station-login:** material design ui ([webex#377](webex#377)) ([aec7034](webex@aec7034)) * **cc-store:** receive webex on init, add store types ([webex#341](webex#341)) ([9648969](webex@9648969)) * **cc-widgets:** ship-all-widgets-together ([webex#345](webex#345)) ([83d5a37](webex@83d5a37)) * cleanup and using mobx-react-lite ([webex#356](webex#356)) ([0b304c4](webex@0b304c4)) * convert npm to yarn ([webex#234](webex#234)) ([432ed3c](webex@432ed3c)) * **release:** add-publish-step-in-tooling ([webex#334](webex#334)) ([ca32235](webex@ca32235)) * rename agent state to user state ([webex#361](webex#361)) ([fe409db](webex@fe409db)) * **samples:** change samples index html hrefs ([webex#367](webex#367)) ([ff126ab](webex@ff126ab)) * **user-state:** receive agent stateChange event ([webex#350](webex#350)) ([21d6ce7](webex@21d6ce7)) ### Features * **cc-components:** setup and move user state sample ui comp ([webex#359](webex#359)) ([16a44d0](webex@16a44d0)) * **cc-store:** add logger from sdk ([webex#354](webex#354)) ([a62494b](webex@a62494b)) * **cc-widgets:** added Agent-Multi-Login-Alert Feature ([webex#364](webex#364)) ([f7d75ca](webex@f7d75ca)) * **release:** add new branch to circleci ([18f7bec](webex@18f7bec)) * **release:** publish pipeline for wxcc widgets ([webex#324](webex#324)) ([864fb52](webex@864fb52)) * taskList and IncomingTask widgets added ([webex#348](webex#348)) ([ce3a619](webex@ce3a619)) * **user-state:** load and change state, client timer ([webex#347](webex#347)) ([f1ccaeb](webex@f1ccaeb)) * **widget-cc-station-login:** Spark 575845 login widget ([webex#239](webex#239)) ([66b8a20](webex@66b8a20)) * **widgets:** added-relogin-logic ([webex#357](webex#357)) ([94dd415](webex@94dd415)) * **widgets:** shifted-timer-to-worker ([webex#352](webex#352)) ([c06fe9c](webex@c06fe9c))

wip(contact-center): update package.json scripts and webpack config

480aed9

sreenara changed the base branch from master to ccwidgets January 7, 2025 17:06

sreenara commented Jan 7, 2025

View reviewed changes

docs/react-samples/package.json Outdated Show resolved Hide resolved

sreenara commented Jan 7, 2025

View reviewed changes

docs/react-samples/src/App.tsx Outdated Show resolved Hide resolved

sreenara commented Jan 7, 2025

View reviewed changes

docs/react-samples/webpack.config.js Outdated Show resolved Hide resolved

sreenara commented Jan 7, 2025

View reviewed changes

webpack.config.js Outdated Show resolved Hide resolved

fix(bundling): fixed all bundling issues

9408855

rarajes2 reviewed Jan 8, 2025

View reviewed changes

docs/react-samples/src/App.tsx Outdated Show resolved Hide resolved

rarajes2 reviewed Jan 8, 2025

View reviewed changes

packages/contact-center/station-login/src/station-login/index.tsx Outdated Show resolved Hide resolved

rarajes2 reviewed Jan 8, 2025

View reviewed changes

packages/contact-center/station-login/package.json Show resolved Hide resolved

rarajes2 added 2 commits January 8, 2025 21:04

fix(bundling): fix store bundling issue. add scss config

853f380

chore(conflicts): resolve conflicts

21125c6

rarajes2 approved these changes Jan 8, 2025

View reviewed changes

mkesavan13 approved these changes Jan 8, 2025

View reviewed changes

rarajes2 merged commit 473cd4f into webex:ccwidgets Jan 8, 2025
1 of 2 checks passed

sreenara added the released on @ccwidgets label Jan 10, 2025

sreenara added the released on @ccconnectors label Feb 5, 2025

		console.log('StationLogin: Teams >>', teams);
		console.log('StationLogin: Login Options >>', loginOptions);

fix(bundling): fixed the multiple React instance and useRef errors #355

fix(bundling): fixed the multiple React instance and useRef errors #355

Uh oh!

Conversation

sreenara commented Jan 7, 2025 • edited by rarajes2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mkesavan13 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sreenara commented Jan 10, 2025

Uh oh!

sreenara commented Feb 5, 2025

Uh oh!

Uh oh!

sreenara commented Jan 7, 2025 •

edited by rarajes2

Loading

coderabbitai bot commented Jan 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)