fix: convert npm to yarn #234

mkesavan13 · 2024-10-21T07:28:16Z

Closes: SPARK-567501

Description

This PR addresses changes in the widgets repo to convert existing npm setup to a yarn monorepo. In this PR, we have moved the entire MeetingsWidgets (@webex/widgets) repo into a separate package while the newer widgets will have newer package with their names and tooling.

Tests performed

Tested by joining my PMR from the sample app for this repo.

Another attendee joined
Sending Screen share
Mute/Unmute for both Video and Audio

Screenshots

Waiting for Others to Join

Another participant joined

Screen share in Widgets

Same Screen share at receiver's side

package.json

Shreyas281299

Changes are fine.
I just have 1 question that there is no yarnrc fie changes - we need to specify the node-linker in yarnrc. But since we only have 1 workspace right now its hard to know which node-linker to use, so maybe we can add the yarnrc changes as part of my PR.

Shreyas281299

I think there should be some automatically created files for yarn, also we need to add the yarnrc file with yarn version atleast.

checksumBehavior: update

nodeLinker: node-modules

npmRegistryServer: "https://registry.npmjs.org"

yarnPath: .yarn/releases/yarn-4.5.0.cjs

This is the yarnrc file that I have in react-widgets created with yarn@4.5.0. We can discuss this.

.circleci/config.yml

.gitignore

.yarnrc.yml

package.json

.circleci/config.yml

packages/@webex/widgets/package.json

adhmenon

LGTM

sreenara

I'm unable to load all the files for review.
Additionally, there seems to be a lot of demo bundles inside the docs/ folder. Are these really required? Why are we committing them?

.yarn/install-state.gz

.yarn/releases/yarn-4.5.1.cjs

sreenara

Changes required in contributing.

sreenara · 2024-10-25T11:34:37Z

packages/@webex/widgets/CONTRIBUTING.md

There are some changes needed here for the new commands right?

I've updated the contributing.md as well

Just one part is left in the Linking components locally section, Install peer dependencies

I'll have to test this to update. Will do so and update it and then merge the PR

mkesavan13 · 2024-10-25T12:04:29Z

I'm unable to load all the files for review.
Additionally, there seems to be a lot of demo bundles inside the docs/ folder. Are these really required? Why are we committing them?

@sreenara - These are available in the master branch as well and is part of the chore commit for release. So, I'd like to keep it as it is for this PR and come back to inspect it while we modernize the WebexMeetings widget

sreenara

Let's fix the changelog in a later PR if needed.

# [1.28.0-alpha.1](webex/widgets@v1.27.5...v1.28.0-alpha.1) (2024-11-14) ### Bug Fixes * **release:** add-mono-repo-support-for-scemantic-release ([webex#246](webex#246)) ([4d2a572](webex@4d2a572)) * convert npm to yarn ([webex#234](webex#234)) ([432ed3c](webex@432ed3c)) * **circleci:** fix-caching-path-in-ci ([webex#243](webex#243)) ([77f40f0](webex@77f40f0)) * **circleci:** fix-test-branch-name ([webex#242](webex#242)) ([d60859a](webex@d60859a)) * **release:** remove-semantic-release-npm ([webex#248](webex#248)) ([c4e7bb1](webex@c4e7bb1)) ### Features * **release:** add-release-script-and-config ([webex#241](webex#241)) ([376e348](webex@376e348)) * **pipeline:** run-npm-publish-for-cc-store ([webex#245](webex#245)) ([d9ef7ae](webex@d9ef7ae))

sreenara · 2024-11-18T14:00:57Z

🎉 This PR is included in version 1.28.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

coderabbitai · 2024-11-18T14:01:05Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sreenara · 2024-11-18T14:15:43Z

🎉 This PR is included in version 1.28.0-eft-pipeline.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.28.0-eft-pipeline.1](webex/widgets@v1.27.5...1.28.0-eft-pipeline.1) (2024-11-18) ### Bug Fixes * convert npm to yarn ([webex#234](webex#234)) ([432ed3c](webex@432ed3c)) ### Features * **release:** create-release-pipeline ([webex#306](webex#306)) ([29bc449](webex@29bc449))

sreenara · 2024-11-19T07:45:13Z

🎉 This PR is included in version 1.27.6-eft.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.27.6-eft.1](webex/widgets@v1.27.5...1.27.6-eft.1) (2024-11-19) ### Bug Fixes * convert npm to yarn ([webex#234](webex#234)) ([432ed3c](webex@432ed3c)) * **pipeline:** create-new-pipeline-for-publishing ([webex#314](webex#314)) ([f507c5c](webex@f507c5c))

sreenara · 2024-11-21T06:13:50Z

🎉 This PR is included in version 1.27.6-eft.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

sreenara · 2024-11-21T06:29:31Z

🎉 This PR is included in version 1.28.0-wxcc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.28.0-wxcc.1](webex/widgets@v1.27.5...v1.28.0-wxcc.1) (2024-11-21) ### Bug Fixes * convert npm to yarn ([webex#234](webex#234)) ([432ed3c](webex@432ed3c)) ### Features * **release:** publish pipeline for wxcc widgets ([webex#324](webex#324)) ([864fb52](webex@864fb52))

## [1.27.6-eft.1](webex/widgets@v1.27.5...v1.27.6-eft.1) (2024-11-21) ### Bug Fixes * convert npm to yarn ([webex#234](webex#234)) ([432ed3c](webex@432ed3c)) * **release:** add-new-tooling ([webex#332](webex#332)) ([cbe6e24](webex@cbe6e24))

## [1.27.6-eft.1](webex/widgets@v1.27.5...v1.27.6-eft.1) (2024-11-21) ### Bug Fixes * **'release:** check-if-we-can-release-tag-with-same-names ([webex#336](webex#336)) ([b9daf11](webex@b9daf11)) * convert npm to yarn ([webex#234](webex#234)) ([432ed3c](webex@432ed3c)) * **release:** add-new-tooling ([webex#332](webex#332)) ([cbe6e24](webex@cbe6e24))

## [1.27.6-eft.1](webex/widgets@v1.27.5...v1.27.6-eft.1) (2024-11-21) ### Bug Fixes * **'release:** check-if-we-can-release-tag-with-same-names ([webex#336](webex#336)) ([b9daf11](webex@b9daf11)) * convert npm to yarn ([webex#234](webex#234)) ([432ed3c](webex@432ed3c)) * **release:** add-new-tooling ([webex#332](webex#332)) ([cbe6e24](webex@cbe6e24)) * **release:** release-a-specific-version ([webex#337](webex#337)) ([a329226](webex@a329226))

## [1.27.6-eft.1](v1.27.5...v1.27.6-eft.1) (2024-11-21) ### Bug Fixes * **'release:** check-if-we-can-release-tag-with-same-names ([webex#336](https://github.com/Shreyas281299/widgets/issues/336)) ([b9daf11](b9daf11)) * convert npm to yarn ([webex#234](https://github.com/Shreyas281299/widgets/issues/234)) ([432ed3c](432ed3c)) * **release:** add-git-tag ([da70031](da70031)) * **release:** add-new-tooling ([webex#332](https://github.com/Shreyas281299/widgets/issues/332)) ([cbe6e24](cbe6e24)) * **release:** release-a-specific-tag ([webex#338](https://github.com/Shreyas281299/widgets/issues/338)) ([8645816](8645816)) * **release:** release-a-specific-version ([webex#337](https://github.com/Shreyas281299/widgets/issues/337)) ([a329226](a329226)) * **release:** run-pipeline-with-new-tag ([424bf4f](424bf4f)) * **release:** try-publishing-tag-again ([webex#339](https://github.com/Shreyas281299/widgets/issues/339)) ([6be4631](6be4631))

sreenara · 2024-11-21T12:44:28Z

🎉 This PR is included in version 1.28.0-ccwidgets.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.28.0-ccwidgets.1](webex/widgets@v1.27.5...v1.28.0-ccwidgets.1) (2024-11-21) ### Bug Fixes * convert npm to yarn ([webex#234](webex#234)) ([432ed3c](webex@432ed3c)) * **release:** add-publish-step-in-tooling ([webex#334](webex#334)) ([ca32235](webex@ca32235)) ### Features * **release:** add new branch to circleci ([18f7bec](webex@18f7bec)) * **release:** publish pipeline for wxcc widgets ([webex#324](webex#324)) ([864fb52](webex@864fb52)) * **widget-cc-station-login:** Spark 575845 login widget ([webex#239](webex#239)) ([66b8a20](webex@66b8a20))

sreenara · 2025-02-05T11:42:48Z

🎉 This PR is included in version 1.28.0-ccconnectors.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.28.0-ccconnectors.1](webex/widgets@v1.27.5...v1.28.0-ccconnectors.1) (2025-02-05) ### Bug Fixes * add material to all components ([webex#376](webex#376)) ([de0ca28](webex@de0ca28)) * **bundling:** fixed the multiple React instance and useRef errors ([webex#355](webex#355)) ([473cd4f](webex@473cd4f)) * **call-control:** add-call-control-widget ([webex#362](webex#362)) ([a677f5e](webex@a677f5e)) * **cc-station-login:** material design ui ([webex#377](webex#377)) ([aec7034](webex@aec7034)) * **cc-store:** receive webex on init, add store types ([webex#341](webex#341)) ([9648969](webex@9648969)) * **cc-widgets:** ship-all-widgets-together ([webex#345](webex#345)) ([83d5a37](webex@83d5a37)) * cleanup and using mobx-react-lite ([webex#356](webex#356)) ([0b304c4](webex@0b304c4)) * convert npm to yarn ([webex#234](webex#234)) ([432ed3c](webex@432ed3c)) * **release:** add-publish-step-in-tooling ([webex#334](webex#334)) ([ca32235](webex@ca32235)) * rename agent state to user state ([webex#361](webex#361)) ([fe409db](webex@fe409db)) * **samples:** change samples index html hrefs ([webex#367](webex#367)) ([ff126ab](webex@ff126ab)) * **user-state:** receive agent stateChange event ([webex#350](webex#350)) ([21d6ce7](webex@21d6ce7)) ### Features * **cc-components:** setup and move user state sample ui comp ([webex#359](webex#359)) ([16a44d0](webex@16a44d0)) * **cc-store:** add logger from sdk ([webex#354](webex#354)) ([a62494b](webex@a62494b)) * **cc-widgets:** added Agent-Multi-Login-Alert Feature ([webex#364](webex#364)) ([f7d75ca](webex@f7d75ca)) * **release:** add new branch to circleci ([18f7bec](webex@18f7bec)) * **release:** publish pipeline for wxcc widgets ([webex#324](webex#324)) ([864fb52](webex@864fb52)) * taskList and IncomingTask widgets added ([webex#348](webex#348)) ([ce3a619](webex@ce3a619)) * **user-state:** load and change state, client timer ([webex#347](webex#347)) ([f1ccaeb](webex@f1ccaeb)) * **widget-cc-station-login:** Spark 575845 login widget ([webex#239](webex#239)) ([66b8a20](webex@66b8a20)) * **widgets:** added-relogin-logic ([webex#357](webex#357)) ([94dd415](webex@94dd415)) * **widgets:** shifted-timer-to-worker ([webex#352](webex#352)) ([c06fe9c](webex@c06fe9c))

mkesavan13 added 3 commits October 21, 2024 12:56

fix: convert npm to yarn

383aafc

Merge remote-tracking branch 'upstream/master' into convert_to_yarn

520fac9

fix: yarn lock

a9d5669

Shreyas281299 reviewed Oct 22, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

Shreyas281299 approved these changes Oct 22, 2024

View reviewed changes

Shreyas281299 requested changes Oct 22, 2024

View reviewed changes

mkesavan13 added 2 commits October 22, 2024 17:41

fix: rename folder to match package name

c9fe972

fix: move to yarn 4.5.1

6d24f89

mkesavan13 commented Oct 24, 2024

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

.gitignore Outdated Show resolved Hide resolved

.yarnrc.yml Outdated Show resolved Hide resolved

package.json Show resolved Hide resolved

fix: nitpick self review comments

09adcc5

Shreyas281299 reviewed Oct 25, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

Shreyas281299 reviewed Oct 25, 2024

View reviewed changes

.circleci/config.yml Show resolved Hide resolved

packages/@webex/widgets/package.json Show resolved Hide resolved

fix: remove main entry in root package

4f0b1f8

Shreyas281299 approved these changes Oct 25, 2024

View reviewed changes

adhmenon approved these changes Oct 25, 2024

View reviewed changes

sreenara reviewed Oct 25, 2024

View reviewed changes

.yarn/install-state.gz Outdated Show resolved Hide resolved

.yarn/releases/yarn-4.5.1.cjs Outdated Show resolved Hide resolved

sreenara requested changes Oct 25, 2024

View reviewed changes

fix: remove install-state and update gitignore

50942eb

sreenara approved these changes Oct 25, 2024

View reviewed changes

mkesavan13 added 3 commits October 25, 2024 18:58

chore(docs): update contribution guide

4a261b8

chore(contributing): update contributing to link components repo

3a76cba

Merge remote-tracking branch 'upstream/master' into convert_to_yarn

df92ffb

mkesavan13 changed the base branch from master to feat/cc-widgets October 29, 2024 12:45

mkesavan13 merged commit 432ed3c into webex:feat/cc-widgets Oct 29, 2024
2 checks passed

sreenara added the released on @eft-pipeline label Nov 18, 2024

sreenara added the released on @eft label Nov 19, 2024

sreenara added the released on @feat/cc-widgets label Nov 21, 2024

sreenara added the released on @ccwidgets label Nov 21, 2024

sreenara added the released on @ccconnectors label Feb 5, 2025

mkesavan13 deleted the convert_to_yarn branch February 5, 2025 12:34

fix: convert npm to yarn #234

fix: convert npm to yarn #234

Uh oh!

Conversation

mkesavan13 commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Closes: SPARK-567501

Description

Tests performed

Screenshots

Waiting for Others to Join

Another participant joined

Screen share in Widgets

Same Screen share at receiver's side

Uh oh!

Uh oh!

Shreyas281299 left a comment

Choose a reason for hiding this comment

Uh oh!

Shreyas281299 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adhmenon left a comment

Choose a reason for hiding this comment

Uh oh!

sreenara left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sreenara left a comment

Choose a reason for hiding this comment

Uh oh!

sreenara Oct 25, 2024

Choose a reason for hiding this comment

Uh oh!

mkesavan13 Oct 25, 2024

Choose a reason for hiding this comment

Uh oh!

mkesavan13 commented Oct 25, 2024

Uh oh!

sreenara left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sreenara commented Nov 18, 2024

Uh oh!

coderabbitai bot commented Nov 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

sreenara commented Nov 18, 2024

Uh oh!

sreenara commented Nov 19, 2024

Uh oh!

sreenara commented Nov 21, 2024

Uh oh!

sreenara commented Nov 21, 2024

Uh oh!

sreenara commented Nov 21, 2024

Uh oh!

sreenara commented Feb 5, 2025

Uh oh!

Uh oh!

mkesavan13 commented Oct 21, 2024 •

edited

Loading

Shreyas281299 left a comment •

edited

Loading

coderabbitai bot commented Nov 18, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)