Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the Custom Elements polyfill to TypeScript #246

Merged
merged 17 commits into from
Feb 11, 2020
Merged

Convert the Custom Elements polyfill to TypeScript #246

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
709cf2c
Apply clang-format to custom-elements polyfill.
rictic Dec 20, 2019
0681bc0
Remove Utilities.setPropertyUnchecked in preparation for conversion t…
rictic Dec 20, 2019
98a5a6d
Convert custom elements polyfill to TypeScript.
rictic Dec 20, 2019
ec0dd97
Remove unnecessary type annotations.
rictic Dec 21, 2019
0224b31
Fixups to the build.
rictic Dec 21, 2019
1968313
Fix compilation and a few other misc test fixes.
rictic Jan 17, 2020
48ed1fb
Trivial change to trigger travis.
rictic Jan 22, 2020
8790abd
Backport eslint changes and apply formatting.
rictic Jan 30, 2020
8a04a72
Some small fixups to address review comments.
rictic Jan 30, 2020
d41ec8d
Emit ES2019 for closure compiler.
rictic Jan 31, 2020
e4f9a07
Make AlreadyConstructedMarker a unique symbol.
rictic Feb 3, 2020
b4d7283
Address review comments.
rictic Feb 4, 2020
42cfd37
Remove invalid trailing comma.
rictic Feb 7, 2020
9ba0df2
Move src to ts_src/ and have it output to src/ to preserve backcompat.
rictic Feb 7, 2020
cf8ce37
Use a branded unconstructable type rather than unique symbol to save …
rictic Feb 7, 2020
ae9ec7e
Use Array<T> instead of T[] consistently.
rictic Feb 7, 2020
650a5c2
Address final review.
rictic Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
packages/*/node_modules/
packages/custom-elements/src/
packages/custom-elements/buildcache
node_modules/
lerna-debug.log
*.min.js*
Expand Down
12 changes: 12 additions & 0 deletions packages/custom-elements/.clang-format
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
BasedOnStyle: Google
AlignAfterOpenBracket: AlwaysBreak
AllowAllParametersOfDeclarationOnNextLine: false
AllowShortBlocksOnASingleLine: false
rictic marked this conversation as resolved.
Show resolved Hide resolved
AllowShortCaseLabelsOnASingleLine: false
AllowShortFunctionsOnASingleLine: None
AllowShortIfStatementsOnASingleLine: false
AllowShortLoopsOnASingleLine: false
BinPackArguments: false
# This breaks async functions sometimes, see
# https://github.com/Polymer/polymer-analyzer/pull/393
# BinPackParameters: false
52 changes: 48 additions & 4 deletions packages/custom-elements/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions packages/custom-elements/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@
],
"license": "BSD-3-Clause",
"scripts": {
"build": "gulp",
"build": "tsc && gulp",
"debug": "rollup -c",
"test": "wct",
"prepack": "npm run build"
"prepack": "npm run build",
"format": "find src -name \"*.ts\" | xargs clang-format --style=file -i"
},
"files": [
"custom-elements.min.js*",
Expand All @@ -32,7 +33,9 @@
"@webcomponents/shadydom": "^1.7.1",
"@webcomponents/template": "^1.4.1",
"@webcomponents/webcomponents-platform": "^1.0.0",
"clang-format": "^1.3.0",
"es6-promise": "4.2.4",
"typescript": "^3.7.3",
"wct-browser-legacy": "^1.0.2"
},
"publishConfig": {
Expand Down
21 changes: 0 additions & 21 deletions packages/custom-elements/src/AlreadyConstructedMarker.js
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions packages/custom-elements/src/CustomElementState.js
View file
Open in desktop

This file was deleted.

62 changes: 0 additions & 62 deletions packages/custom-elements/src/Deferred.js
View file
Open in desktop

This file was deleted.

65 changes: 0 additions & 65 deletions packages/custom-elements/src/Patch/Document.js
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions packages/custom-elements/src/Patch/DocumentFragment.js
View file
Open in desktop

This file was deleted.

Loading