Convert the Custom Elements polyfill to TypeScript #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#247 should fix the build error. |
rictic
force-pushed
the
ts-custom-elements
branch
from
2c3179b
to
d9a57f8
Compare
|
Cool, tests are passing now, PTAL |
bicknellr
reviewed
Jan 30, 2020
bicknellr
reviewed
Jan 31, 2020
There was a problem hiding this comment.
WDYT about using Array<T> throughout instead of T[]? AFAICT, Array<X|Y> seems to be preferred over (X|Y)[], but then T[] is used instead of Array<T> when T is a single identifier - is there a reason for mixing them?
Found a few places that are now ??/?.-able while reading through this again but I think it's not worth worrying about for this PR.
bicknellr
reviewed
Feb 4, 2020
TypeScript doesn't care, but it does make it invalid JSON.
rictic
force-pushed
the
ts-custom-elements
branch
from
92e8ca4
to
9ba0df2
Compare
bicknellr
approved these changes
Feb 11, 2020
|
Err, LGTM once we get the tests working, but it looks like you just need to be added as admin or collaborator on this repo? |
|
Sauce tests passing in #268 but the discussion is here, so I'll merge this change and close that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially breaking change: the individual source files (including native-shim.js) are now in lib instead of src. If that would break users I can refactor to move them back to
src/Also, for sanity, I enabled automatic formatting. As a result, the changes are probably best reviewed one commit at a time.