-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the ethereum-blackhole (the 0x address) for the from
address for tests on mainnet and testnet
#6689
Merged
Muhammad-Altabba
merged 7 commits into
4.x
from
6640-mainnet-release-tests-estimategas-error
Jan 8, 2024
Merged
Use the ethereum-blackhole (the 0x address) for the from
address for tests on mainnet and testnet
#6689
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e494509
use the ethereum-blackhole (the 0x address) for the from address for …
Muhammad-Altabba 9f08d08
temp allow black box tests to always run
Muhammad-Altabba a133760
temp allow black box tests to always run
Muhammad-Altabba edbfac6
restore running condition for `Black Box Tests`
Muhammad-Altabba 8d57d0a
fix a typo inside `Black Box Tests` workflow
Muhammad-Altabba 6bba077
Merge branch '4.x' into 6640-mainnet-release-tests-estimategas-error
Muhammad-Altabba c6672af
Merge branch '4.x' into 6640-mainnet-release-tests-estimategas-error
Muhammad-Altabba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blackbox Tests were not failing on sepolia, could you double check old logs for it. and run tests with above change. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jdevcs , yes tests where not failing for sepolia. But I thought to use an address that would never cause the tests to fail in the future as a precaution. Or what do you think?
And yes, I run the tests and they all run with success here: https://github.com/web3/web3.js/actions/runs/7419127171/job/20188191757?pr=6689
Thanks,