Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the ethereum-blackhole (the 0x address) for the from address for tests on mainnet and testnet #6689

Merged
merged 7 commits into from
Jan 8, 2024
Merged

Use the ethereum-blackhole (the 0x address) for the from address for tests on mainnet and testnet #6689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e494509
use the ethereum-blackhole (the 0x address) for the from address for …
Muhammad-Altabba Jan 4, 2024
9f08d08
temp allow black box tests to always run
Muhammad-Altabba Jan 5, 2024
a133760
temp allow black box tests to always run
Muhammad-Altabba Jan 5, 2024
edbfac6
restore running condition for `Black Box Tests`
Muhammad-Altabba Jan 5, 2024
8d57d0a
fix a typo inside `Black Box Tests` workflow
Muhammad-Altabba Jan 5, 2024
6bba077
Merge branch '4.x' into 6640-mainnet-release-tests-estimategas-error
Muhammad-Altabba Jan 8, 2024
c6672af
Merge branch '4.x' into 6640-mainnet-release-tests-estimategas-error
Muhammad-Altabba Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/black_box_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.mode }}
node-version: ${{ matrix.node }}
- run: yarn
- run: tar -czf /tmp/web3-${{ matrix.node }}.js.tar.gz --exclude="./.git" ./
- uses: actions/upload-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e_network_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
INFURA_SEPOLIA_HTTP: ${{ secrets.INFURA_SEPOLIA_HTTP }}
INFURA_MAINNET_HTTP: ${{ secrets.INFURA_MAINNET_HTTP }}
MODE: ${{ matrix.mode }}
TEST_ACCOUNT_ADDRESS: ${{ fromJSON('{"sepolia":"0xa127C5E6a7E3600Ac34A9a9928E52521677e7211","mainnet":"0x98AF911164f9d4E0f5983ed114949c3Bfe3ADc9d"}')[matrix.network] }}
TEST_ACCOUNT_ADDRESS: ${{ fromJSON('{"sepolia":"0x0000000000000000000000000000000000000000","mainnet":"0x0000000000000000000000000000000000000000"}')[matrix.network] }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blackbox Tests were not failing on sepolia, could you double check old logs for it. and run tests with above change. thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdevcs , yes tests where not failing for sepolia. But I thought to use an address that would never cause the tests to fail in the future as a precaution. Or what do you think?
And yes, I run the tests and they all run with success here: https://github.com/web3/web3.js/actions/runs/7419127171/job/20188191757?pr=6689
Thanks,

ALLOWED_SEND_TRANSACTION: ${{ secrets.E2E_TESTS_ALLOWED_SEND_TRANSACTION }}
TEST_ACCOUNT_PRIVATE_KEY: ${{ secrets.TEST_ACCOUNT_PRIVATE_KEY }}
strategy:
Expand Down
Loading