-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the ethereum-blackhole (the 0x address) for the from
address for tests on mainnet and testnet
#6689
Use the ethereum-blackhole (the 0x address) for the from
address for tests on mainnet and testnet
#6689
Conversation
…tests on mainnet and testnet
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Deploying with Cloudflare Pages
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6689 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 214 214
Lines 8171 8171
Branches 2200 2200
=======================================
Hits 7472 7472
Misses 699 699
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -30,7 +30,7 @@ jobs: | |||
INFURA_SEPOLIA_HTTP: ${{ secrets.INFURA_SEPOLIA_HTTP }} | |||
INFURA_MAINNET_HTTP: ${{ secrets.INFURA_MAINNET_HTTP }} | |||
MODE: ${{ matrix.mode }} | |||
TEST_ACCOUNT_ADDRESS: ${{ fromJSON('{"sepolia":"0xa127C5E6a7E3600Ac34A9a9928E52521677e7211","mainnet":"0x98AF911164f9d4E0f5983ed114949c3Bfe3ADc9d"}')[matrix.network] }} | |||
TEST_ACCOUNT_ADDRESS: ${{ fromJSON('{"sepolia":"0x0000000000000000000000000000000000000000","mainnet":"0x0000000000000000000000000000000000000000"}')[matrix.network] }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blackbox Tests were not failing on sepolia, could you double check old logs for it. and run tests with above change. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jdevcs , yes tests where not failing for sepolia. But I thought to use an address that would never cause the tests to fail in the future as a precaution. Or what do you think?
And yes, I run the tests and they all run with success here: https://github.com/web3/web3.js/actions/runs/7419127171/job/20188191757?pr=6689
Thanks,
Description
Fixes #6640
The tests can now be run with no issues. Tested here: https://github.com/web3/web3.js/actions/runs/7419127171/job/20188191757?pr=6689
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.