-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4x ENS functionality #4794
4x ENS functionality #4794
Conversation
This pull request introduces 1 alert when merging 0ec2465 into ea41c55 - view on LGTM.com new alerts:
|
i think unit tests for the resolver class would be good, other then that LGTM |
@luu-alex Resolver class is only sending transactions and sending eth_calls for reads so I think we can test it in integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could do this in a subsequent PR, but I think packages/web3-eth-ens/src/ens.ts
should have sanity check unit tests that test this._resolver
is receiving the expected arguments from ENS
class - this ensures the user facing API never changes accidentally
@spacesailor24 i included add sanity check for resolver in the ens epic, so we can merge this one in |
Description
#4552
#4602
#4553
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.