Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4x ENS functionality #4794

Merged
merged 16 commits into from
Mar 3, 2022
Merged

4x ENS functionality #4794

merged 16 commits into from
Mar 3, 2022

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Feb 24, 2022

Description

#4552
#4602
#4553

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@jdevcs jdevcs added the 4.x 4.0 related label Feb 24, 2022
@jdevcs jdevcs self-assigned this Feb 24, 2022
packages/web3-eth-ens/src/resolver.ts Outdated Show resolved Hide resolved
packages/web3-eth-ens/src/resolver.ts Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2022

This pull request introduces 1 alert when merging 0ec2465 into ea41c55 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@jdevcs jdevcs marked this pull request as ready for review February 25, 2022 16:17
@luu-alex
Copy link
Contributor

i think unit tests for the resolver class would be good, other then that LGTM

@jdevcs
Copy link
Contributor Author

jdevcs commented Feb 28, 2022

i think unit tests for the resolver class would be good, other then that LGTM

@luu-alex Resolver class is only sending transactions and sending eth_calls for reads so I think we can test it in integration tests.

@jdevcs jdevcs requested a review from luu-alex February 28, 2022 13:16
Copy link
Contributor

@spacesailor24 spacesailor24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could do this in a subsequent PR, but I think packages/web3-eth-ens/src/ens.ts should have sanity check unit tests that test this._resolver is receiving the expected arguments from ENS class - this ensures the user facing API never changes accidentally

@luu-alex
Copy link
Contributor

luu-alex commented Mar 3, 2022

@spacesailor24 i included add sanity check for resolver in the ens epic, so we can merge this one in

@luu-alex luu-alex merged commit fc8acc1 into 4.x Mar 3, 2022
@luu-alex luu-alex deleted the junaid/4xensresolverfns branch March 3, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants