Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ENS GET functions from 1 to 4.x #4602

Closed
luu-alex opened this issue Dec 6, 2021 · 1 comment
Closed

Migrate ENS GET functions from 1 to 4.x #4602

luu-alex opened this issue Dec 6, 2021 · 1 comment
Assignees
@jdevcs
Labels
4.x 4.0 related

Comments

@luu-alex
Copy link
Contributor

luu-alex commented Dec 6, 2021 •
edited by jdevcs
Loading

Description

Migrate the following functions and config file from web3-eth-ens ens 1.x branch to 4.x rewrite.
Functions:

  • supportsInterface
  • getAddress
  • getPubkey
  • getContent
  • getContenthash
  • getMultihash
  • checkNetwork

Deprecated functions from 1.x

  • resolver
  • owner

Acceptance Criteria

  • All functions above should be migrated (except deprecated functions)
  • All functions should be covered with unit tests

Links and resources
@luu-alex luu-alex added the 4.x 4.0 related label Dec 6, 2021
@mconnelly8
Copy link

Hey team! Please add your planning poker estimate with ZenHub @jdevcs @luu-alex @nazarhussain

@luu-alex luu-alex changed the title Migrate Resolver ENS GET functions from 1 to 4.x Migrate ENS GET functions from 1 to 4.x Feb 22, 2022
@jdevcs jdevcs assigned jdevcs and unassigned luu-alex Feb 24, 2022
@jdevcs jdevcs mentioned this issue Feb 24, 2022
Merged
16 tasks
@luu-alex luu-alex closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdevcs jdevcs

Labels
4.x 4.0 related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luu-alex @jdevcs @mconnelly8