[wptrunner] Reset permissions between tests for Chrome #48610
Merged
+53
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
WeizhongX
reviewed
Oct 18, 2024
WeizhongX
reviewed
Oct 18, 2024
WeizhongX
reviewed
Oct 18, 2024
WeizhongX
reviewed
Oct 18, 2024
Similar to web-platform-tests#48106, permission changes may leak between tests that use the same WebDriver session (i.e., browser process). For now, add a Chromium-specific `Browser.resetPermissions` call to reset permission defaults. To consolidate calls that reset state, refactor the WebDriver executor's testharness window management to align with web-platform-tests#45735.
jonathan-j-lee
force-pushed
the
wptrunner/chrome/reset-permissions
branch
from
3c7e678
to
4583e60
Compare
WeizhongX
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #48106, permissions granted with certain lifetimes may leak between tests. For now, add a Chromium-specific
Browser.resetPermissionscall to enforce resetting permission defaults.To consolidate calls that reset state, refactor the WebDriver executor's testharness window management to align with #45735.
Tested in Chromium, in https://crrev.com/c/5930453 and locally:
(
MediaStream-id.https.htmlshould no longer grant thecamerapermission toGUM-permissions-query.https.html.)