[wptrunner] Clear cookies between testharness tests for Chrome #48106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around web-platform-tests#48078 with CDP [0] in the absence of a robust cross-vendor solution. [0]: https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-clearBrowserCookies
wpt-pr-bot
added
infra
wptrunner
WeizhongX
approved these changes
Sep 12, 2024
jonathan-j-lee
added a commit
to jonathan-j-lee/wpt
that referenced
this pull request
Oct 14, 2024
Similar to web-platform-tests#48106, permission changes may leak between tests that use the same WebDriver session (i.e., browser process). For now, add a Chromium-specific `Browser.resetPermissions` call to reset permission defaults. To consolidate calls that reset state, refactor the WebDriver executor's testharness window management to align with web-platform-tests#45735.
jonathan-j-lee
added a commit
to jonathan-j-lee/wpt
that referenced
this pull request
Oct 18, 2024
Similar to web-platform-tests#48106, permission changes may leak between tests that use the same WebDriver session (i.e., browser process). For now, add a Chromium-specific `Browser.resetPermissions` call to reset permission defaults. To consolidate calls that reset state, refactor the WebDriver executor's testharness window management to align with web-platform-tests#45735.
jonathan-j-lee
added a commit
that referenced
this pull request
Oct 18, 2024
Similar to #48106, permission changes may leak between tests that use the same WebDriver session (i.e., browser process). For now, add a Chromium-specific `Browser.resetPermissions` call to reset permission defaults. To consolidate calls that reset state, refactor the WebDriver executor's testharness window management to align with #45735.
jonathan-j-lee
added a commit
to jonathan-j-lee/wpt
that referenced
this pull request
Nov 5, 2024
This workaround allows tests to pass without performing their own cookie cleanup. Per meeting discussion, revert web-platform-tests#48106 until there's a portable solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around #48078 with CDP in the absence of a robust cross-vendor solution.