-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-special URL path tests #4586
Conversation
Notifying @Sebmaster, @domenic, @mikewest, @rubys, @sideshowbarker, @smola, @tomalec, @xiaojunwu, and @zcorpan. (Learn how reviewing works.) |
This is not ready to be reviewed yet. Many existing tests need to change as well. |
Firefox (nightly channel)Testing web-platform-tests at revision e1384f4 |
Chrome (unstable channel)Testing web-platform-tests at revision cb30546 All results/url/url-constructor.html
/url/url-setters.html
/url/url-origin.html
/url/a-element-xhtml.xhtml
/url/a-element.html
/url/a-element-origin.html
/url/a-element-origin-xhtml.xhtml
|
These tests depend on #4406 landing first. |
This allows paths to be empty for non-special URLs and also takes that into account when serializing. Tests: web-platform-tests/wpt#4586. Fixes #212.
This allows paths to be empty for non-special URLs and also takes that into account when serializing. Tests: web-platform-tests/wpt#4586. Fixes #212.
@annevk can you rebase these on master? |
4bc60b1
to
825b632
Compare
Rebased. |
These used to be part of #4406.
825b632
to
13aacc4
Compare
This allows paths to be empty for non-special URLs and also takes that into account when serializing. Tests: web-platform-tests/wpt#4586. Fixes #212.
Refs: web-platform-tests/wpt#4586 Refs: #11887 PR-URL: #12058 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
PR-URL: nodejs#12507 Refs: web-platform-tests/wpt#4586 Refs: nodejs#11887 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #12507 Refs: web-platform-tests/wpt#4586 Refs: #11887 Reviewed-By: James M Snell <jasnell@gmail.com>
See whatwg/url#212 for details.