url: change path parsing for non-special URLs #12058
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Contributor
Author
|
cc @nodejs/url |
TimothyGu
reviewed
Mar 27, 2017
Member
TimothyGu
left a comment
TimothyGu
left a comment
There was a problem hiding this comment.
More in-depth review tomorrow, hopefully.
src/node_url.cc
Outdated
Member
There was a problem hiding this comment.
Isn't continue equivalent to p--?
Contributor
Author
There was a problem hiding this comment.
That's right! Updated to use continue instead of p--. thanks :)
watilde
force-pushed
the
feature/file-path
branch
from
ceacc41 to
b0e8cae
Compare
Contributor
Author
Contributor
Author
|
Failed CIs doesn't seem to be related to this PR. |
watilde
force-pushed
the
feature/file-path
branch
from
b0e8cae to
6169f87
Compare
Contributor
Author
|
rebased to resolve conflicts. |
jasnell
approved these changes
Mar 30, 2017
joyeecheung
approved these changes
Mar 31, 2017
TimothyGu
suggested changes
Mar 31, 2017
src/node_url.cc
Outdated
Member
Contributor
Author
There was a problem hiding this comment.
Oh good to know it! Thanks. I will update it soon.
src/node_url.cc
Outdated
Member
There was a problem hiding this comment.
Ditto, but in this case you have to set URL_FLAGS_HAS_FRAGMENT
watilde
force-pushed
the
feature/file-path
branch
2 times, most recently
from
a3ed1d4 to
8772487
Compare
Contributor
Author
TimothyGu
reviewed
Apr 2, 2017
src/node_url.cc
Outdated
Member
There was a problem hiding this comment.
Sorry for not being clear. Keep the url->query.clear() there, in addition to setting the flag.
Contributor
Author
There was a problem hiding this comment.
oops, I misunderstood it sorry! updated.
This changes to the way path parsing for non-special URLs. It allows paths to be empty for non-special URLs and also takes that into account when serializing. Fixes: nodejs#11962 Refs: whatwg/url#213
watilde
force-pushed
the
feature/file-path
branch
from
8772487 to
303d71f
Compare
Updates: + Bring tests url-setter-tests from WPT, and put it as JavaScript + Comment out unpassed tests Refs: web-platform-tests/wpt#5112 Refs: nodejs#11887
watilde
force-pushed
the
feature/file-path
branch
from
303d71f to
b103e6e
Compare
Contributor
Author
TimothyGu
approved these changes
Apr 2, 2017
Contributor
Author
watilde
added a commit
that referenced
this pull request
Apr 3, 2017
This changes to the way path parsing for non-special URLs. It allows paths to be empty for non-special URLs and also takes that into account when serializing. Fixes: #11962 Refs: whatwg/url#213 PR-URL: #12058 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
watilde
added a commit
that referenced
this pull request
Apr 3, 2017
Refs: web-platform-tests/wpt#4586 Refs: #11887 PR-URL: #12058 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
watilde
added a commit
that referenced
this pull request
Apr 3, 2017
Updates: + Bring tests url-setter-tests from WPT, and put it as JavaScript + Comment out unpassed tests Refs: web-platform-tests/wpt#5112 Refs: #11887 PR-URL: #12058 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
Updates: + Bring tests url-setter-tests from WPT, and put it as JavaScript + Comment out unpassed tests Refs: web-platform-tests/wpt#5112 Refs: nodejs#11887 PR-URL: nodejs#12058 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
Fixes #11962.
Checklist
make -j4 testAffected core subsystem(s)
url, test