Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GridNG] Allow stretching in block-axis. #26535

Merged
merged 1 commit into from
Nov 16, 2020

Commits on Nov 16, 2020

  1. [GridNG] Allow stretching in block-axis.

    This block-stretching logic as:
    https://chromium-review.googlesource.com/c/chromium/src/+/2513771
    ... did for the inline-axis.
    
    Previously we didn't have the concept of "stretching" the block-axis
    instead relying on the parent layout algorithm to set a fixed
    block-size.
    
    This allow stretching (similar to the inline-dimension).
    
    The failing tests (which I'll update in the test expectations) are due
    to this specification issue:
    w3c/csswg-drafts#5713
    
    The changes in layout_replaced.cc are needed to transfer the stretched
    size through the aspect-ratio.
    
    Bug: 1045599
    Change-Id: Ifdd8653d81a1ead84a0afbf5ebd31ba0b75dc8ee
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523743
    Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
    Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
    Reviewed-by: David Grogan <dgrogan@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#827854}
    bfgeek authored and chromium-wpt-export-bot committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    bc52c19 View commit details
    Browse the repository at this point in the history