[GridNG] Allow stretching in block-axis. #26535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 14, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2523743
branch
from
17def41
to
c5ca000
Compare
This block-stretching logic as: https://chromium-review.googlesource.com/c/chromium/src/+/2513771 ... did for the inline-axis. Previously we didn't have the concept of "stretching" the block-axis instead relying on the parent layout algorithm to set a fixed block-size. This allow stretching (similar to the inline-dimension). The failing tests (which I'll update in the test expectations) are due to this specification issue: w3c/csswg-drafts#5713 The changes in layout_replaced.cc are needed to transfer the stretched size through the aspect-ratio. Bug: 1045599 Change-Id: Ifdd8653d81a1ead84a0afbf5ebd31ba0b75dc8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523743 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#827854}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2523743
branch
from
c5ca000
to
bc52c19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This block-stretching logic as:
https://chromium-review.googlesource.com/c/chromium/src/+/2513771
... did for the inline-axis.
Previously we didn't have the concept of "stretching" the block-axis
instead relying on the parent layout algorithm to set a fixed
block-size.
This allow stretching (similar to the inline-dimension).
The failing tests (which I'll update in the test expectations) are due
to this specification issue:
w3c/csswg-drafts#5713
The changes in layout_replaced.cc are needed to transfer the stretched
size through the aspect-ratio.
Bug: 1045599
Change-Id: Ifdd8653d81a1ead84a0afbf5ebd31ba0b75dc8ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523743
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827854}