Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aankirz: Fixes interop-invalidyear #3229

Closed

Conversation

Aankirz
Copy link

@Aankirz Aankirz commented Mar 26, 2023

Description

Fixes issue 2975

  • To improve the user experience
  • Whenever user enters any invalid year (Interop) , redirects to a sorry page.

Review Information

Changes

  • Added a new file interop-404.js in webapp/components
  • Modified interop_handler.go

Copy link
Contributor

@DanielRyanSmith DanielRyanSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Aankirz! Can you provide a screenshot of the build working locally?

webapp/interop_handler.go Outdated Show resolved Hide resolved
webapp/components/interop-404.js Outdated Show resolved Hide resolved
Co-authored-by: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
@Aankirz
Copy link
Author

Aankirz commented Mar 26, 2023

Thanks for the fix @Aankirz! Can you provide a screenshot of the build working locally?

So sorry 😔, but I am getting installation issues so I wrote the code through logic (checked it line by line) and can't produce a local run, actually I asked it in my prev issue assigned, but I guess mentors might be busy.

Can you pls guide me, I followed every step ran script using DOCKER, but I'm getting these installation errors: (After the step of "npm test" in webapp) My chromedriver path : "/opt/homebrew/bin/chromedriver", (Specs: Macos M1) I tried using chat gpt and googling, but was not able to resolve 😢

Thanks for the Help ✨

Screenshot 2023-03-26 at 1 50 18 AM

Screenshot 2023-03-26 at 1 50 32 AM

@Aankirz
Copy link
Author

Aankirz commented Mar 27, 2023

@DanielRyanSmith , can I pls get a link of the community where I can ask my doubts 🫥, Thanks a lott ✨

@DanielRyanSmith
Copy link
Contributor

Hey @Aankirz, this is a fine place to talk to us about questions you might have.

Specs: Macos M1

Hmm, we have a known issue with running this project on M1 chips. I'll let you know if we come up with a solution for this.

@Aankirz
Copy link
Author

Aankirz commented Mar 28, 2023

Should I open a issue regarding this ? 🙂

@Aankirz
Copy link
Author

Aankirz commented Mar 28, 2023

Hey @Aankirz, this is a fine place to talk to us about questions you might have.

Specs: Macos M1

Hmm, we have a known issue with running this project on M1 chips. I'll let you know if we come up with a solution for this.

Screenshot 2023-03-28 at 11 45 51 AM

Now it started with no errors, but when I go to localhost:8080, then the browser says

'localhost didn’t send any data.
ERR_EMPTY_RESPONSE'

Can you pls help in this ? 🥲

@Aankirz
Copy link
Author

Aankirz commented Mar 28, 2023

@DanielRyanSmith Just to confirm is npm test the final command after which wpt.fyi website will be started on my localhost ??

@DanielRyanSmith
Copy link
Contributor

@Aankirz unfortunately, I think you will have probably running the application locally until we investigate the ability to run for arm-based chips. This issue was filed, so you are not the only person to run into this issue. I'm sorry, but I do not have an answer for how to fix this just yet.

@Aankirz
Copy link
Author

Aankirz commented Mar 29, 2023

@DanielRyanSmith , I changed my laptop and now it's a windows 11

and now getting this error (I'm using docker dev environment): 🥲
WhatsApp Image 2023-03-29 at 19 40 53

@Aankirz
Copy link
Author

Aankirz commented Mar 29, 2023

And just want to know what spec are you using to run this repo pls ? 🫥

@racheljay
Copy link
Contributor

Hi @Aankirz! Can you tell me what you get when you post the following commands? Run uname -m and it will tell you the architecture of the computer you're currently using. If it says arm64 that means you won't be able to run the environment on your computer because inotify is incompatible, and the environment requires this to run. If it's not arm64 try running apt search inotify-tools and post the response you get.

@Aankirz
Copy link
Author

Aankirz commented Mar 30, 2023

No it's not arm64, I've changed my laptop and I tried the command:

Screenshot (3)

Thanks for your time @racheljay , but can you help me with this , This is the error I'm getting in my windows 11: inotifywait

Screenshot (4)

I also tried to install intoify tools using : sudo apt-get install inotify-tools

But still getting this:
Screenshot (5)

Can you pls guide me how did you installed, Thanks in advance

@racheljay
Copy link
Contributor

Hi @Aankirz. I'm not sure the exact steps you've taken so far so I will just tell you everything I did to set up my environment that worked for me.

  1. I installed WSL2 on my computer (which is using Windows 10).
  2. After installing WSL2 I made sure I was using the Ubuntu terminal that came with WSL2 and the cloned the repository within WSL2.
  3. I ran docker pull webplatformtests/wpt.fyi:latest only in my first initial setup.
  4. In one terminal window I ran ./util/docker-dev/run.sh and let it run.
  5. In a new terminal window I then ran ./util/docker-dev/web_server.sh and waited for that to run. For me, this one takes a couple of minutes to complete.
  6. After these are both running, I opened a third terminal window and ran ./util/docker-dev/dev_data.sh.
    After I did all of these steps I was able to see the site running on localhost:8080.

Let me know if you have any questions about this. Also I noticed you were running docker pull webplatformtests/wpt.fyi:latest along with a comment and another command. I would not run these all together. And you should not need to run docker pull webplatformtests/wpt.fyi:latest again if you already have the docker image.

@Aankirz
Copy link
Author

Aankirz commented Apr 1, 2023

Thaaaaaaaaaaanks a lotttttt @racheljay 🥹,

It's now working fine 😊, Finally

Screenshot (6)

@Aankirz Aankirz closed this Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interop 20XX page should display "data unavailable" for invalid years
3 participants