Skip to content

chore(vscode): add icon, clean dist artifacts #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

chore(vscode): add icon, clean dist artifacts #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,4 @@ fixtures-test-*/
tests-dist/
.vscode-test/
packages/vscode/*.vsix
packages/vscode/icon.png
5 changes: 5 additions & 0 deletions packages/vscode/.vscodeignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
**
!icon.png
!dist
!LICENSE.md
!package.json
7 changes: 4 additions & 3 deletions packages/vscode/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ The extension activates automatically when your workspace contains Rstest config

## Configuration

| Setting | Type | Scope | Default | Description |
| ---------------------------- | -------- | -------- | -------------------------------- | ------------------------------------------------------------- |
| `rstest.testFileGlobPattern` | string[] | Resource | `["**/*.test.*", "**/*.spec.*"]` | Glob pattern(s) used to discover test files in the workspace. |
| Setting | Type | Default | Description |
| ---------------------------- | -------- | -------------------------------- | ------------------------------------------------------------------------------- |
| `rstest.testFileGlobPattern` | string[] | `["**/*.test.*", "**/*.spec.*"]` | Glob pattern(s) used to discover test files in the workspace. |
| `rstest.logLevel` | string | `default` | Controls Output channel verbosity; set to `debug` for extra diagnostic logging. |

## How it works

Expand Down
2 changes: 2 additions & 0 deletions packages/vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"name": "rstest",
"icon": "icon.png",
"displayName": "Rstest",
"publisher": "rstack",
"description": "VS Code extension for Rstest",
Expand Down Expand Up @@ -52,6 +53,7 @@
}
},
"scripts": {
"preinstall": "[ -f icon.png ] || curl https://assets.rspack.rs/rstest/rspress-logo-512x512.png --output icon.png",
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preinstall script uses shell syntax that may not work on Windows. Consider using a cross-platform solution like downloading the icon through a Node.js script or including the icon file directly in the repository.

Suggested change
"preinstall": "[ -f icon.png ] || curl https://assets.rspack.rs/rstest/rspress-logo-512x512.png --output icon.png",
"preinstall": "node ./scripts/download-icon.js",

Copilot uses AI. Check for mistakes.
"build": "rslib build",
"lint": "biome check . --diagnostic-level=warn",
"build:local": "SOURCEMAP=true rslib build",
Expand Down
3 changes: 2 additions & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ packages:

strictPeerDependencies: false
autoInstallPeers: false
hoistPattern: []
# for vsce
hoistPattern: ['@secretlint/*']
Loading