Skip to content

Conversation

@fi3ework
Copy link
Member

Summary

  • add icon
  • clean vsix dist tar
  • fix hoist deps to make vsce happy

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 15, 2025 06:07
@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for rstest-dev ready!

Name Link
🔨 Latest commit b299f34
🔍 Latest deploy log https://app.netlify.com/projects/rstest-dev/deploys/68ef3a206f92b40008b11c56
😎 Deploy Preview https://deploy-preview-617--rstest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the VSCode extension configuration by adding an icon, cleaning up distribution artifacts, and resolving dependency hoisting issues for the vsce packaging tool.

Key changes:

  • Added icon support with automatic download fallback
  • Updated workspace configuration to hoist @secretlint dependencies for vsce compatibility
  • Improved documentation table formatting and added new configuration option

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
pnpm-workspace.yaml Added hoistPattern for @secretlint dependencies to satisfy vsce requirements
packages/vscode/package.json Added icon field and preinstall script to download icon if missing
packages/vscode/README.md Reformatted configuration table and added logLevel setting documentation
packages/vscode/.vscodeignore Added new file to specify which files to include in the extension package

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

}
},
"scripts": {
"preinstall": "[ -f icon.png ] || curl https://assets.rspack.rs/rstest/rspress-logo-512x512.png --output icon.png",
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preinstall script uses shell syntax that may not work on Windows. Consider using a cross-platform solution like downloading the icon through a Node.js script or including the icon file directly in the repository.

Suggested change
"preinstall": "[ -f icon.png ] || curl https://assets.rspack.rs/rstest/rspress-logo-512x512.png --output icon.png",
"preinstall": "node ./scripts/download-icon.js",

Copilot uses AI. Check for mistakes.
@fi3ework fi3ework merged commit 5aa6fa8 into main Oct 15, 2025
17 checks passed
@fi3ework fi3ework deleted the v branch October 15, 2025 06:26
@9aoy 9aoy mentioned this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant