Skip to content

rate-limit routes calculation performed during topology broadcast updates #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

rate-limit routes calculation performed during topology broadcast updates #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions routes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ package mesh
import (
"math"
"sync"

"golang.org/x/time/rate"
)

type unicastRoutes map[PeerName]PeerName
Expand All @@ -21,6 +23,7 @@ type routes struct {
recalc chan<- *struct{}
wait chan<- chan struct{}
action chan<- func()
limiter *rate.Limiter
// [1] based on *all* connections, not just established &
// symmetric ones
}
Expand All @@ -41,6 +44,8 @@ func newRoutes(ourself *localPeer, peers *Peers) *routes {
wait: wait,
action: action,
}
// rate limiter that permits up to rate 2 and permits bursts of at most 4 tokens
r.limiter = rate.NewLimiter(2, 4)
go r.run(recalculate, wait, action)
return r
}
Expand Down Expand Up @@ -191,6 +196,12 @@ func (r *routes) run(recalculate <-chan *struct{}, wait <-chan chan struct{}, ac
}

func (r *routes) calculate() {

// rate limit the number of calls to calculate()
if r.limiter.Allow() == false {
return
}

r.peers.RLock()
r.ourself.RLock()
var (
Expand Down