Skip to content

rate-limit routes calculation performed during topology broadcast updates #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

rate-limit routes calculation performed during topology broadcast updates #106

wants to merge 1 commit into from

Conversation

@murali-reddy
Copy link
Contributor

@murali-reddy murali-reddy commented May 20, 2019 •
edited
Loading

Fixes #105 rate-limit routes calculation done when a gossip topology update is received

bboreham
bboreham approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like a comment on the "magic numbers" 2 and 4, and maybe a comment on the TODO, but can merge now and fix that later.

bboreham
bboreham reviewed Jun 6, 2019
View reviewed changes
routes.go Outdated
type broadcastRoutes map[PeerName][]PeerName

var limiter = rate.NewLimiter(2, 4)
var pendingCalculate = false
Copy link
Contributor

@bboreham bboreham Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can these be members of routes rather than globals

@murali-reddy
Copy link
Contributor Author

murali-reddy commented Jun 18, 2019

Sorry, current fix seems to cause some regression. I did some scaling tests (>100 nodes). Connections seems to go into pending, retrying state forever. Narrowed down problem is due to limiter.Wait. Strangely moment delay is introduced due to wait, connections are not established. though routes calculate() is an asyn activity to connection processing.

I need to investigate further.

This was referenced Aug 22, 2019
Open
Closed
Closed
Merged
@murali-reddy
Copy link
Contributor Author

murali-reddy commented Oct 1, 2019 •
edited
Loading

On further testing rate limiting as solution did not provide predictable workload irrespetice of cluster size. Closing thie PR in favour of in #117, #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bboreham bboreham bboreham approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rate-limit routes calculation done when a gossip topology update is received

2 participants

@murali-reddy @bboreham