Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node.js 22 #848

Merged
merged 6 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@ module.exports = {
'@vue/standard'
],
parserOptions: {
parser: 'babel-eslint'
parser: '@babel/eslint-parser'
},
rules: {
'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off'
'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
'vue/multi-word-component-names': 'warn',
'vue/no-reserved-component-names': 'warn'
},
overrides: [
{
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/netlify-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
with:
env-file: .env.development.mock

- name: Use Node.js 14.x
uses: actions/setup-node@v3.7.0
- name: Use Node.js 22.x
uses: actions/setup-node@v4.0.3
with:
node-version: 14.x
node-version: 22.x
- run: npm ci
- run: npm run build

Expand Down Expand Up @@ -48,10 +48,10 @@ jobs:
with:
env-file: .env.development.prod

- name: Use Node.js 14.x
uses: actions/setup-node@v3.7.0
- name: Use Node.js 22.x
uses: actions/setup-node@v4.0.3
with:
node-version: 14.x
node-version: 22.x
- run: npm ci
- run: npm run build

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [12, 14, 15]
node-version: [22]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we keep other versions also? We always run different versions before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to always test the current version and then perhaps any future versions we hope to update to soon


steps:
- uses: actions/checkout@v3.5.3
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:15 as builder
FROM node:22 as builder

WORKDIR /src/app
COPY ./package.json ./package-lock.json ./
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ services:
ui:
env_file:
- .env
image: node:15
image: node:22
user: "node"
working_dir: /home/node/app
volumes:
Expand Down
Loading
Loading