Update to Node.js 22 #848
Update to Node.js 22 #848
Conversation
|
Deployment previews on netlify for branch
|
| const { data } = await call | ||
| return data | ||
| } catch (err) { | ||
| if (err.response.code === '401') { |
There was a problem hiding this comment.
It's not safe to remove the 401 check which was deliberately introduced here 00120ef
When loading the application, a call against login is made to check whether the user is already logged in. If a 401 is returned, this means the user is not, but it's an expected outcome, so null is being returned instead of throwing an error.
There was a problem hiding this comment.
This 401 check doesn't work because response.code is always undefined. That's why I switched to using response.status in my latest patch. Therefore, this code snippet was already throwing an error on every page load for unauthenticated users. But even if this did return null for 401s, this would still throw an error in store/auth.js because null can't be destructured in .then(({ user }) => {...}.
| @@ -48,7 +48,9 @@ const actions = { | |||
| }) | |||
| .catch((error) => { | |||
| commit('auth_error') | |||
| throw error | |||
| if (error.response.status !== 401) { | |||
There was a problem hiding this comment.
I'm not sure this is equivalent to what happens now as auth_error is being comitted on 401 responses when previously it was not. API returning 401 is expected and not to be considered an error.
There was a problem hiding this comment.
auth_error is already being committed on 401s (see previous comment).
| @@ -16,7 +16,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| node-version: [12, 14, 15] | |||
| node-version: [22] | |||
There was a problem hiding this comment.
Why don't we keep other versions also? We always run different versions before.
There was a problem hiding this comment.
We probably want to always test the current version and then perhaps any future versions we hope to update to soon
No description provided.