-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Slyblime package #8000
Add Slyblime package #8000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repo link: Slyblime
Results help
Packages added:
- Slyblime
Processing package "Slyblime"
- ERROR: No valid semver tags found at https://github.com/s-clerc/slyblime/tags for the package "Slyblime".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: WARNING
Repo link: Slyblime
Results help
Packages added:
- Slyblime
Processing package "Slyblime"
- WARNING: Creating a readme for your package will help users understand what it does and how to use it
- WARNING: The binding ['shift+enter'] is also defined in default bindings but is masked with a 'context'
- File: Default.sublime-keymap
- WARNING: The binding ['shift+enter'] is also defined in default bindings but is masked with a 'context'
- File: Default.sublime-keymap
- WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary
- WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: WARNING
Repo link: Slyblime
Results help
Packages added:
- Slyblime
Processing package "Slyblime"
- WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary
- WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.
- WARNING: The binding ['shift+enter'] is also defined in default bindings but is masked with a 'context'
- File: Default.sublime-keymap
- WARNING: The binding ['shift+enter'] is also defined in default bindings but is masked with a 'context'
- File: Default.sublime-keymap
You create a loop in Why do you bundle a Is the usage of Other than that, I didn't review eveything because it's too much for me, but the architecture in general seems fine. |
Unfortunately, that's a mistake. I've committed a fix, and it will appear in the next tagged release.
Yeah, in the case you cite that
It isn't and I did submit a PR, but to allow new users to start using it as soon as possible I've bundled it. In addition, it's possible that in the future there are more plugin-specific scopes.
Yeah, I can change that, but I was worried that then there are two Lisp entries in the panel which would confuse people. |
This package integrates with the preexisting Slynk server from the Sly IDE to offer a rich Lisp development experience. There is no similar package.