-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lisp] Rescopes parens
to be consistent with the guidelines and Clojure.
#2312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As scope naming guidelines explicitly allow the usasge of meta.group
and meta.parens
("based on appropriate semantics"), I'd be curious about the motivation to change meta.group
to meta.parens
.
I am not a Lisp expert, but with regards to other syntaxes meta.group
seems to be used more frequently and appears to be the common meta scope for groups of expressions.
I think I switched to I'm not a Sublime Syntax expert by any means. If you think that it would be better to use |
Agree with scope naming guidelines being a bit unclear at this point. As I didn't follow/attend the discussion about when which of them is appropriate, I'd propably wait for someone who did. But with regards to your description, your choice feels more appropriate. I'd use groups for operator precedence like use cases only, as well. Not sure about your concerns about color schemes as they can use parts of scopes as selectors. If a selector in a color scheme addresses |
I was talking about if a colour scheme wanted to colour things like |
I'd love to converge the work on Lisp by a few different people to a single course of action, if only to try and make the integration process easier. I see you've already been providing feedback on #2387 @s-clerc. Is that in a state where it supersedes this here? As a comment about |
Closing as superseded by #3896. |
Changes
parens
is changed frompunctuation.definition
... topunctuation.section
.()
is included as a language constant.Rationale
This is to more strictly follow the scoping guidelines which state that blocks of code delineated in brackets should be scoped in
meta.parens
withpunctuation.section.parens
for the brackets.The use of the
.definition
scope led to (perceived) incorrect colouring in Monokai Pro, and this change bringsLisp.sublime-syntax
in line withClojure.sublime-syntax
which currently usespunctuation.section.parens
.Adding
()
as alanguage.constant
because()
≡nil
for the sake of consistency.By necessity.