Skip to content

Workflow Update - Fix macOS Binary #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 8, 2024
Merged

Workflow Update - Fix macOS Binary #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b0f998
workflow adjustments
HB9HIL Aug 7, 2024
c049578
forge config
HB9HIL Aug 7, 2024
e9c3b4a
use the newer checkout version
HB9HIL Aug 7, 2024
bef7bb3
npm name pattern fix
HB9HIL Aug 7, 2024
26b67e1
run the workflow
HB9HIL Aug 7, 2024
95378b7
set correct repo and branch
HB9HIL Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions .github/workflows/electron.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,29 @@
# name of your github action
name: BuildnPub_WLGate
# this will help you specify where to run
on:
push:
branches:
# this will run on the electron branch
- master
workflow_dispatch:

jobs:
build_on_linux:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: actions/setup-node@master
with:
node-version: 21
- name: install dependencies
run: npm install
- name: build
run: npm run make -- --platform linux --arch=x64
- name: publish
- name: build and publish
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: npm run publish --from-dry-run
run: npx electron-forge publish --platform linux --arch=x64

build_on_mac:
runs-on: macos-14
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: actions/setup-node@master
with:
node-version: 21
Expand All @@ -42,26 +37,22 @@ jobs:
npm install -g appdmg@0.6.6
- name: install dependencies
run: npm install
- name: build
run: npm run make --arch=universal
- name: publish
- name: build and publish
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: npm run publish --from-dry-run
run: npx electron-forge publish --arch=universal


build_on_win:
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: actions/setup-node@master
with:
node-version: 21
- name: install dependencies
run: npm install
- name: build
run: npm run make
- name: publish
- name: build and publish
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: npm run publish --from-dry-run
run: npx electron-forge publish
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,4 @@ Enjoy

#### Contributing
Contribution is welcome. PRs will only be accepted against the Dev-Branch.

3 changes: 2 additions & 1 deletion forge.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@ module.exports = {
},
{
name: '@electron-forge/maker-dmg',
config: { format: 'ULFO' },
config: { format: 'UDZO' },
platforms: ['darwin'],
arch: ['universal'],
},
{
name: '@electron-forge/maker-deb',
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "WaveLog_Gate_by_DJ7NT",
"name": "wavelog-gate-by-dj7nt",
Copy link
Contributor Author

@HB9HIL HB9HIL Aug 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@int2001

This is something we should take a look at. The "old" name was WaveLog_Gate_by_DJ7NT but this one can fail in some environments due to the required npm name pattern (kebab-case and lowercase characters). Maybe we can just call it wavelog-gate here and place DJ7NT in the productName (Ln 3) or in the description (Ln 4)?

image

"productName": "WaveLogGate",
"description": "Gateway for connecting WSJT-* and FLRig to Wavelog",
"keywords": [],
Expand Down