Workflow Update - Fix macOS Binary #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HB9HIL
commented
Aug 7, 2024
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "WaveLog_Gate_by_DJ7NT", | |||
| "name": "wavelog-gate-by-dj7nt", | |||
Contributor
Author
There was a problem hiding this comment.
This is something we should take a look at. The "old" name was WaveLog_Gate_by_DJ7NT but this one can fail in some environments due to the required npm name pattern (kebab-case and lowercase characters). Maybe we can just call it wavelog-gate here and place DJ7NT in the productName (Ln 3) or in the description (Ln 4)?
Merged
int2001
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with compiling the mac binary as Universal version (should work on ARM64 and x86 Systems). I fixed this issue by adjusting the workflow.
In addition to that I removed the dedicated build commands as the
npx electron-forge publishcommand does the build anyway. This way I was able to reduce the workflow time from 4.5 Minutes so 2.5 Minutes.A Log of this workflow can be found here
The output files of this workflow as example here