Skip to content

update dependencies, fix test case #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2022
Merged

update dependencies, fix test case #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c22785
update dependencies, fix test case
bobfang Feb 17, 2022
501b9ce
added semicolons
bobfang Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

### v0.39.1
* Update vulnerable dependencies
* Update example dependencies (removed vulenerable express-browserify)

### v0.37.0
* BREAKING CHANGES INTRODUCED:
* All options parameters for all methods are coverted to be lowerCamelCase
Expand Down
12,518 changes: 10,299 additions & 2,219 deletions examples/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 6 additions & 4 deletions examples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"scripts": {
"start": "node server.js",
"postinstall": "./scripts/postinstall.sh",
"dev": "../scripts/run-dev.sh && node server.js"
"watchify": "npx watchify static/browserify-app.js -o static/scripts/browserify-bundle.js --debug --verbose",
"develop": "npm-run-all --parallel watchify start"
},
"cacheDirectories": [
"node_modules"
Expand All @@ -14,17 +15,18 @@
"defaults": "^1.0.3",
"dotenv": "^8.2.0",
"express": "^4.17.1",
"express-browserify": "^1.0.3",
"express-rate-limit": "^5.1.3",
"express-secure-only": "^0.2.1",
"ibm-watson": "^6.0.2",
"jquery": "^3.5.1",
"object.assign": "^4.0.4",
"vcap_services": "^0.7.1",
"watson-speech": "^0.38.1",
"watchify": "^4.0.0",
"watson-speech": "^0.39.0",
"webpack": "^5.18.0",
"webpack-dev-middleware": "^4.1.0",
"whatwg-fetch": "^3.0.0"
"whatwg-fetch": "^3.0.0",
"npm-run-all": "^4.1.5"
},
"engines": {
"node": ">=12"
Expand Down
9 changes: 2 additions & 7 deletions examples/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
const express = require('express');
const app = express();

const expressBrowserify = require('express-browserify');
const webpackDevMiddleware = require('webpack-dev-middleware');
const webpack = require('webpack');
const webpackConfig = require('./webpack.config');
Expand Down Expand Up @@ -52,14 +51,10 @@ const secure = require('express-secure-only');
app.use(secure());
app.use(express.static(__dirname + '/static'));

// set up express-browserify to serve browserify bundles for examples
const isDev = app.get('env') === 'development';
// use watchify to build browserify bundle and serve it
app.get(
'/browserify-bundle.js',
expressBrowserify('static/browserify-app.js', {
watch: isDev,
debug: isDev
})
express.static(__dirname + '/static/scripts/browserify-bundle.js')
);

// set up webpack-dev-middleware to serve Webpack bundles for examples
Expand Down
Loading