update dependencies, fix test case #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jeff-arn
reviewed
Feb 17, 2022
speech-to-text/recognize-file.js
Outdated
| // new behavior https://github.com/bergos/nodeify-fetch/blob/v2.2.2/lib/patchResponse.js | ||
| // seems like we just have to check if the body is readable | ||
| if (response.body.readable) { | ||
| return response.body |
There was a problem hiding this comment.
we should use semicolons here. we'll need to check and make sure we are linting on pre-commit
There was a problem hiding this comment.
did a npm run lint and it didn't find anything. proceeded to add semicolons in the next commit manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating package dependencies to remediate whitesource scan findings
watchifyto invoke browserify on the example app instead of using express-browserify (removed)npm-run-allto run watchify and server.js for example app in local development mode (old dev script didn't exist anyway)mochato latest versionnodeify-fetchto v2.2.2should transcribe files via URLtestnodeify-fetchAPI changes between v1.0.1 to v.2.2.2npmfrom dependencies^0.39.0so it pulls the latest available release (currently v0.39.0) and will receive update via v0.39.1 (this PR)Checklist
npm testpassesTests