Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #9

Merged
merged 10 commits into from
Dec 4, 2023
Merged

Add unit tests #9

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d95392f
tests: add MockCourse unit tests
fiveoutofnine Dec 3, 2023
07d6a6b
tests: add Par unit tests
fiveoutofnine Dec 3, 2023
6cab196
chore: remove compiler warnings
fiveoutofnine Dec 3, 2023
39364aa
tests: add CurtaGolf unit tests
fiveoutofnine Dec 3, 2023
1d2bc99
chore: run forge fmt src
fiveoutofnine Dec 3, 2023
18f01cc
refactor: add MIN_COMMIT_AGE as a constant param
fiveoutofnine Dec 3, 2023
5e92aac
refactor: allowedOpcodes -> getAllowedOpcodes
fiveoutofnine Dec 3, 2023
51adb67
docs: fix some comments
fiveoutofnine Dec 3, 2023
f0cd628
fix: purity checker
fiveoutofnine Dec 4, 2023
43b3572
docs: update comments
fiveoutofnine Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: fix some comments
  • Loading branch information
@fiveoutofnine
fiveoutofnine committed Dec 3, 2023
commit 51adb670486315b6fdb2ee68a734568c9be58819
10 changes: 5 additions & 5 deletions test/CurtaGolf.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ contract CurtaGolfTest is BaseTest {
curtaGolf.submit(1, EFFICIENT_SOLUTION, solver1, 0);
}

/// @notice Test that revealing a solution to a nonexistent course reverts.
/// @notice Test that submitting a solution to a nonexistent course reverts.
function test_submit_NonexistentCourse_Reverts() public {
bytes32 key = keccak256(abi.encode(solver1, EFFICIENT_SOLUTION, 0));

Expand All @@ -114,7 +114,7 @@ contract CurtaGolfTest is BaseTest {
curtaGolf.submit(2, EFFICIENT_SOLUTION, solver1, 0);
}

/// @notice Test that revealing a solution with invalid opcodes reverts.
/// @notice Test that submitting a solution with invalid opcodes reverts.
function test_submit_PollutedSolution_Reverts() public {
// Ban all opcodes.
vm.prank(owner);
Expand All @@ -132,7 +132,7 @@ contract CurtaGolfTest is BaseTest {
curtaGolf.submit(1, EFFICIENT_SOLUTION, solver1, 0);
}

/// @notice Test that revealing an incorrect solution reverts.
/// @notice Test that submitting an incorrect solution reverts.
function test_submit_IncorrectSolution_Reverts() public {
// Commit the key.
bytes32 key = keccak256(abi.encode(solver1, INCORRECT_SOLUTION, 0));
Expand All @@ -146,7 +146,7 @@ contract CurtaGolfTest is BaseTest {
curtaGolf.submit(1, INCORRECT_SOLUTION, solver1, 0);
}

/// @notice Test the emitted events and storage updates upon revealing
/// @notice Test the emitted events and storage updates upon submitting
/// solutions in the following order:
/// 1. `solver1` submits an inefficient solution but becomes the king.
/// 2. `solver2` submits an efficient solution and becomes the new king.
Expand Down Expand Up @@ -288,7 +288,7 @@ contract CurtaGolfTest is BaseTest {
// `submitDirectly`
// -------------------------------------------------------------------------

/// @notice Test the emitted events and storage updates upon revealing
/// @notice Test the emitted events and storage updates upon submitting
/// solutions in the following order:
/// 1. `solver1` submits an inefficient solution but becomes the king.
/// 2. `solver2` submits an efficient solution and becomes the new king.
Expand Down