Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #9

Merged
merged 10 commits into from
Dec 4, 2023
Merged

Add unit tests #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d95392f
tests: add MockCourse unit tests
fiveoutofnine Dec 3, 2023
07d6a6b
tests: add Par unit tests
fiveoutofnine Dec 3, 2023
6cab196
chore: remove compiler warnings
fiveoutofnine Dec 3, 2023
39364aa
tests: add CurtaGolf unit tests
fiveoutofnine Dec 3, 2023
1d2bc99
chore: run forge fmt src
fiveoutofnine Dec 3, 2023
18f01cc
refactor: add MIN_COMMIT_AGE as a constant param
fiveoutofnine Dec 3, 2023
5e92aac
refactor: allowedOpcodes -> getAllowedOpcodes
fiveoutofnine Dec 3, 2023
51adb67
docs: fix some comments
fiveoutofnine Dec 3, 2023
f0cd628
fix: purity checker
fiveoutofnine Dec 4, 2023
43b3572
docs: update comments
fiveoutofnine Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: run forge fmt src
  • Loading branch information
@fiveoutofnine
fiveoutofnine committed Dec 3, 2023
commit 1d2bc99630df225e7f502b07c4a53b7d3ce9d7b4
4 changes: 3 additions & 1 deletion src/CurtaGolf.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ contract CurtaGolf is ICurtaGolf, KingERC721, Owned {
/// @inheritdoc ICurtaGolf
function setAllowedOpcodes(uint32 _courseId, uint256 _allowedOpcodes) external onlyOwner {
// Revert if the course does not exist.
if (address(getCourse[_courseId].course) == address(0)) revert CourseDoesNotExist(_courseId);
if (address(getCourse[_courseId].course) == address(0)) {
revert CourseDoesNotExist(_courseId);
}

// Set allowed opcodes for the course.
allowedOpcodes[_courseId] = _allowedOpcodes;
Expand Down
7 changes: 6 additions & 1 deletion src/utils/PurityChecker.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@ import { IPurityChecker } from "../interfaces/IPurityChecker.sol";
/// @notice A purity checker checks whether a given contract is pure, i.e. that
/// it's restricted to a set of instructions/opcodes, by analyzing its bytecode.
contract PurityChecker is IPurityChecker {
function check(bytes memory _code, uint256 _allowedOpcodes) external pure override returns (bool satisfied) {
function check(bytes memory _code, uint256 _allowedOpcodes)
external
pure
override
returns (bool satisfied)
{
return _allowedOpcodes > 0;
/* assembly ("memory-safe") {
function isPush(opcode) -> ret {
Expand Down