Skip to content

Commit

Permalink
CI/azure: improve on flakiness by avoiding libtool wrappers
Browse files Browse the repository at this point in the history
Install curl binaries into MinGW bin folder and use that
for the tests in order to avoid libtool wrapper binaries.

The libtool wrapper binaries (not scripts) on Windows seem
to be one of the possible causes for the following issues:

1. Process output can be lost in the wrapper process chain.
2. Killing the wrapper process does not kill the actual one.

Derived from curl#5904
Closes curl#6049
  • Loading branch information
mback2k committed Oct 16, 2020
1 parent bfd35d5 commit 354afc8
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions .azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ stages:
displayName: 'configure $(name)'

- script: make
displayName: 'make'
displayName: 'make && cd tests && make'

- script: make test-nonflaky
displayName: 'test'
Expand Down Expand Up @@ -188,11 +188,14 @@ stages:
- script: $(container_cmd) -l -c "cd $(echo '%cd%') && ./buildconf && ./configure $(configure)"
displayName: 'configure $(name)'

- script: $(container_cmd) -l -c "cd $(echo '%cd%') && make"
- script: $(container_cmd) -l -c "cd $(echo '%cd%') && make && cd tests && make"
displayName: 'make'

- script: $(container_cmd) -l -c "cd $(echo '%cd%') && make install && PATH=/usr/bin:/bin find . -type f -path '*/.libs/*.exe' -print -execdir mv -t .. {} \;"
displayName: 'install'

- script: $(container_cmd) -l -c "cd $(echo '%cd%') && make test-nonflaky"
displayName: 'test'
env:
AZURE_ACCESS_TOKEN: "$(System.AccessToken)"
TFLAGS: "-r $(tests)"
TFLAGS: "-vc /usr/bin/curl.exe -r $(tests)"

0 comments on commit 354afc8

Please sign in to comment.