CI/azure: fix flakiness by avoiding libtool wrappers on Windows #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
|
@bagder do you think it would be possible to also "install" the testsuite binaries (libtests, servers and unittests) in order to avoid the libtool wrappers which I think are the root cause for the Windows CI flakiness? At the moment there is unfortunately no Makefile target for this. AppVeyor is basically out of scope for this, because it is building and testing within the MSYS2 environment, but the Azure DevOps builds are native cross-compiled Windows binaries which don't depend on such an environment for execution. |
|
Possible? sure! Tricky? Probably! As we don't want them installed by regular users who do 'make install' in the root build dir, we can't use the normal automake targets for install but we have to do something more special-purpose. |
mback2k
force-pushed
the
azure-ci-avoid-libtool-wrappers
branch
from
c54dfff to
027adea
Compare
mback2k
force-pushed
the
azure-ci-avoid-libtool-wrappers
branch
from
0a5a52b to
1cf7664
Compare
mback2k
force-pushed
the
azure-ci-avoid-libtool-wrappers
branch
from
1cf7664 to
adca2ae
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mback2k
force-pushed
the
azure-ci-avoid-libtool-wrappers
branch
from
adca2ae to
9a87c7e
Compare
mback2k
force-pushed
the
azure-ci-avoid-libtool-wrappers
branch
from
9a87c7e to
fb01c53
Compare
mback2k
added a commit
to mback2k/curl
that referenced
this pull request
Oct 12, 2020
Avoid using our own, potentially installed, curl for the test reporting APIs in case it is broken. Follow up to curl#6049
This was referenced Oct 12, 2020
mback2k
force-pushed
the
azure-ci-avoid-libtool-wrappers
branch
from
fb01c53 to
957458b
Compare
mback2k
force-pushed
the
azure-ci-avoid-libtool-wrappers
branch
from
f431c26 to
b722111
Compare
mback2k
force-pushed
the
azure-ci-avoid-libtool-wrappers
branch
2 times, most recently
from
1731d0a to
4b50250
Compare
Install curl binaries into MinGW bin folder and use that for the tests in order to avoid libtool wrapper binaries. The libtool wrapper binaries (not scripts) on Windows seem to be one of the root causes for the following issues: 1. Process output can be lost in the wrapper process chain. 2. Killing the wrapper process does not kill the real one. Derived from curl#5904 Closes curl#6049
mback2k
force-pushed
the
azure-ci-avoid-libtool-wrappers
branch
2 times, most recently
from
97b9248 to
957c519
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 29, 2024
Ref: 354afc8 curl#6049 Follow-up to e53523f curl#14859
vszakats
added a commit
that referenced
this pull request
Oct 29, 2024
Avoid the `curl.exe` wrapper binary created by libtool, and run the real `curl.exe` directly for tests and version information. This solution was used in Azure jobs. I missed it when migrating jobs to GHA. Applies to tests run in the `mingw, AM x86_64 c-ares U` job, which has seen unexplained flakiness. Ref: 354afc8 #6049 Follow-up to e53523f #14859 Closes #15437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install curl binaries into MinGW bin folder and use that
for the tests in order to avoid libtool wrapper binaries.
The libtool wrapper binaries (not scripts) on Windows seem
to be the root cause of the following issues:
Derived from #5904