fix: escape non-member top identifiers #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "message": "Got an error during or right after parsing `interface Iroha`: The name \"Iroha\" of type \"interface\" is already seen", | |||
Member
Author
There was a problem hiding this comment.
That means is->was, right? What does s/ part mean?
Member
There was a problem hiding this comment.
Ah sorry, bad habit s/ meaning replace... something we do at the w3c :(
Member
There was a problem hiding this comment.
(I think "s/" is a vim thing)
Member
Author
There was a problem hiding this comment.
Oh, TIL an interesting w3c (edit: vim) syntax 😁
Edit: So I have to admit I'm not very familiar with vim commands. 😮
lib/webidl2.js
Outdated
| error(`The name "${name}" of type "${names.get(name)}" is already seen`); | ||
| const unescaped = unescape(name); | ||
| if (names.has(unescaped)) { | ||
| error(`The name "${unescaped}" of type "${names.get(unescaped)}" is already seen`); |
Member
There was a problem hiding this comment.
Sorry, nit below belongs here.
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #228
This adds
escapedNamefield for top level definitions, and also correctly checks duplication: