Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes so far:
[NoInterfaceObject]support and made a single[Exposed]mandatory to align with ongoing/upcoming Web IDL spec changes. Fixed how[Exposed]arguments are processed as that changed in webidl2..argumentswhen checking[Global]validity; I'm not sure what that check was for and it doesn't seem to work anymore anyway..specialproperty instead of the.getter,.setter,.deleter,.stringifier,.staticpropertiesnameproperties for indexed/named getters/setters, instead ofnull. webidl2 is now sometimes returning undefined and sometimes returning the empty string (I think via the prototype chain? There is nonameown property.)Tests still failing:
_analyzeMembers (lib/constructs/interface.js:367:15)which seems to prohibit any underscores from appearing. I'm unsure what the intent of the original code was, or the intent of the webidl2 changes, which seem likely to be those in fix: escape non-member top identifiers w3c/webidl2.js#229. This is causing lots of early failures which might mask other issues.sequence<sequence<USVString>>inURLSearchParams.webidlis being treated as something likesequence<USVString>. I fixed several similar failures, which were caused by webidl2 switchingidlTypefrom the inner type to an array containing the inner type. I'm unsure why this one remains.Help very much appreciated from anyone who is able to figure these remaining things out.
/cc @saschanaz