-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excludes APG Landmark Examples Pages from site search #362
Excludes APG Landmark Examples Pages from site search #362
Conversation
✅ Deploy Preview for wai-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cc @yatil @mcking65 if this change lands, note that the links in the top comment will be excluded from the WAI website's site-wide search. https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/ will still be searchable which also links to these pages. My comment on why is here: #358 (comment) |
Thanks. We're having issues with the site build and need to do important updates tomorrow, Thursday. Then y'all are off Friday. And I'm traveling for the next 2 weeks. I'll see if there's a time we can coordinate an update. Otherwise, it will be later in October. |
Safe travels!
Okay understood. I'll also be off Oct 16 - 30 as well, so you can check in with @ccanash for support if I'm not available when you're back. |
c1934cb
to
69e5878
Compare
@remibetin Thank you for following up on this! |
Thanks @howard-e I have merged this PR. |
Fixes #357 by excluding the following pages from the site search:
I followed jekyll-tipue-search's README on doing the exclusions.
@shawna-slh please let me know if how the paths to the files are defined is okay. I verified locally with my
wai-website
build that all 12 pages are excluded from the site search.