Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excludes APG Landmark Examples Pages from site search #362

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for wai-website ready!

Name Link
🔨 Latest commit 69e5878
🔍 Latest deploy log https://app.netlify.com/sites/wai-website/deploys/662a01ecaade93000839d0f0
😎 Deploy Preview https://deploy-preview-362--wai-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@howard-e
Copy link
Contributor Author

howard-e commented Oct 4, 2023

cc @yatil

@mcking65 if this change lands, note that the links in the top comment will be excluded from the WAI website's site-wide search. https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/ will still be searchable which also links to these pages.

My comment on why is here: #358 (comment)

@shawna-slh
Copy link
Collaborator

Thanks. We're having issues with the site build and need to do important updates tomorrow, Thursday. Then y'all are off Friday. And I'm traveling for the next 2 weeks. I'll see if there's a time we can coordinate an update. Otherwise, it will be later in October.

@howard-e
Copy link
Contributor Author

howard-e commented Oct 4, 2023

And I'm traveling for the next 2 weeks.

Safe travels!

I'll see if there's a time we can coordinate an update. Otherwise, it will be later in October.

Okay understood. I'll also be off Oct 16 - 30 as well, so you can check in with @ccanash for support if I'm not available when you're back.

@remibetin remibetin force-pushed the dont-search-apg-landmarkexamples branch from c1934cb to 69e5878 Compare April 25, 2024 07:10
@shawna-slh
Copy link
Collaborator

@remibetin Thank you for following up on this!

@remibetin remibetin merged commit cafcf7b into w3c:master Jul 9, 2024
4 checks passed
@remibetin
Copy link
Member

Thanks @howard-e I have merged this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARIA Practices Guide breaks search
3 participants