-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove APG from search index #358
Conversation
Band-aid fix for w3c#357
|
Name | Link |
---|---|
🔨 Latest commit | 06d31b7 |
After discussing with @alflennik, we found that the violating pages are inside ARIA/apg/patterns/landmarks and found here on the website. Historically, these pages didn’t follow the expected format to allow them to include the correct front matter metadata like the other pages in WAI APG do, because of unique functionality on those pages that wouldn’t work when included in the WAI website. There has already been discussions in the past to rewrite these pages to align with how other pages work, not just for the WAI APG’s purposes. So I’d figure that change is still coming.
For the technical aspect, I’m unsure but I’d think removing APG from the search wouldn’t be preferred if there's alternatives. Is it possible to deindex that specific list of 12 pages / paths? cc @mcking65 |
Happy to do that if you provide the fix. |
Noted thanks, I've submitted #362. |
Thank you @howard-e! Yes, removing just those 12 pages is the best approach. The offending landmark pages have been on my mind ever since the redesign launch last year ... they are a bit of a nightmare. Just last weekend I was working on gathering the related issues and assembling a plan to present to the task force. I still have some work to do before I have a coherent proposal. I'd like to get fixing them added to the 2023 milestones if I can drum up the needed people power. So, I hope that removal is a short-lived fix. @howard-e, please create an issue in wai-aria-practices to track removing it when the time is right. I will link that issue to the landmark example rework plan when I have it in place. |
Done in w3c/wai-aria-practices#270 |
Band-aid fix for #357