Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-pseudo-4] Clarify text decorations in ::spelling-error and ::grammar-error #9633

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

schenney-chromium
Copy link
Contributor

Issue #9233
Add a note for authors on the requirements for custom text-decorations inside ::spelling-error pseudo (and grammar).

Issue w3c#9233
Add a note for authors on the requirements for custom text-decorations inside ::spelling-error pseudo (and grammar).
Copy link
Collaborator

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way too long for the problem it's solving.

@fantasai
Copy link
Collaborator

I switched up the rules to use text-decoration instead of text-decoration-line to kind-of nudge people to use the shorthand also when trying to overwrite it. We could add a note, but this behavior should be very explicitly specified in the definition of these values; so I'm not sure how much we really need a note in this appendix here. But definitely we should keep it minimal if we add anything.

@schenney-chromium
Copy link
Contributor Author

I think something is needed because authors are quite likely to overlook this, just setting a text-decoration-color and expecting the UA rendered dots or squiggles to pick up the color, at least given the way Chrome renders error markers.

I simplified it to be more direct and moved it up to the section discussing properties in highlight pseudos.

This is basically a bandaid on the disconnect between ::spelling-error defined here and text-decoration-line: spelling-error defined in the text-decor spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants