Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text-decor] [css-pseudo] text-decoration-line:: spelling-error inside ::spelling-error pseudo (and grammar) #9233

Open
schenney-chromium opened this issue Aug 24, 2023 · 2 comments
Assignees

Comments

@schenney-chromium
Copy link
Contributor

It was resolved in #7522 to ignore all other text-decoration properties when the text-decoration-lineproperty has value spelling-error or grammar-error.

When ''spelling-error'' or ''grammar-error'' apply, the user agent must disregard the other sub-properties of 'text-decoration', as well any other properties typically affecting the appearance of line decorations (such as 'text-underline-position', 'color', 'stroke', or 'fill') when rendering these decorations.

A side effect of this change is that

::spelling-error { text-decoration-color: blue; }

has no effect because the default text-decoration-line for ::spelling-error is spelling-error (as one would hope).

Same applies to ::grammar-error.

I propose that we accept this as working as intended, and update the spec to clearly say that ::spelling-error will only respect text decoration properties when text-decoration-line is present with a value other than spelling-error or grammar-error.

::spelling-error {
   text-decoration-line: underline;
   text-decoration-style: wavy;
   text-decoration-color: blue;
}
@schenney-chromium
Copy link
Contributor Author

@fantasai is the intent to say, yes, this is working as intended and update the spec as necessary?

schenney-chromium added a commit to schenney-chromium/csswg-drafts that referenced this issue Nov 25, 2023
Issue w3c#9233
Add a note for authors on the requirements for custom text-decorations inside ::spelling-error pseudo (and grammar).
@schenney-chromium
Copy link
Contributor Author

PR to do the edit: #9633

fantasai added a commit that referenced this issue Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Unslotted
Development

No branches or pull requests

2 participants