-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carousel Examples: ad note informing authors that aria-rolesdescription uses the language of the page #2358
Conversation
@mcking65 @jnurthen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer adding the suggested text.
@jnurthen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jongund, looks great, merging.
Fixes #2355 by:
Adding a note to the carousel examples that the
aria-roledescription
value uses the language of the page, similar to labeling of controls.Auto-Rotating Image Carousel Example with Buttons for Slide Control
Auto-Rotating Image Carousel with Tabs for Slide Control Example
WAI Preview Link