Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel Examples: ad note informing authors that aria-rolesdescription uses the language of the page #2358

Merged
merged 6 commits into from
Mar 21, 2023

Conversation

jongund
Copy link
Contributor

@jongund jongund commented May 24, 2022

Fixes #2355 by:

Adding a note to the carousel examples that the aria-roledescription value uses the language of the page, similar to labeling of controls.

Auto-Rotating Image Carousel Example with Buttons for Slide Control
Auto-Rotating Image Carousel with Tabs for Slide Control Example


WAI Preview Link

@jongund
Copy link
Contributor Author

jongund commented Mar 8, 2023

@mcking65 @jnurthen
I was cleaning up my old pull requests and this was one from about a year ago for the carousel examples. It adds an additional bullet to the Properties and States descriptions for the aria-roledescription property value to be in the language of the page. It only adds 2 lines of content to each carousel example file.

Copy link
Member

@jnurthen jnurthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer adding the suggested text.

@jongund
Copy link
Contributor Author

jongund commented Mar 20, 2023

@jnurthen
I added your suggest edit to include "... and should be localized by the author."

@jongund jongund requested a review from jnurthen March 20, 2023 16:55
@mcking65 mcking65 changed the title added note related that aria-rolesdescription uses the language of the page Carousel Examples: ad note informing authors that aria-rolesdescription uses the language of the page Mar 21, 2023
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jongund, looks great, merging.

@mcking65 mcking65 merged commit d02c812 into main Mar 21, 2023
@mcking65 mcking65 deleted the carousel-role-description-i18n branch March 21, 2023 17:59
@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. documentation enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy labels Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

carousel pattern should use localized "aria-roledescription"s for its elements
3 participants