Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carousel pattern should use localized "aria-roledescription"s for its elements #2355

Closed
Abdull opened this issue May 24, 2022 · 1 comment · Fixed by #2358
Closed

carousel pattern should use localized "aria-roledescription"s for its elements #2355

Abdull opened this issue May 24, 2022 · 1 comment · Fixed by #2358
Assignees
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force

Comments

@Abdull
Copy link

Abdull commented May 24, 2022

The ARIA Authoring Practices Guide carousel pattern page currently gives the following information:

The carousel container has the aria-roledescription property set to carousel.
...
Each slide container has role group with the property aria-roledescription set to slide.

But according to Accessible Rich Internet Applications (WAI-ARIA) 1.3:

[aria-roledescription defines] a human-readable, author-localized description for the role of an element.

I understand localized description here as language-localized. Thus, the given aria-roledescriptions carousel and slide are only valid within an English language locale. And indeed, with my computer's German locale, NVDA awkwardly starts spelling "c-a-r-o-u-s-e-l" instead of communicating "Karussell".

Assuming I understood aria-roledescription's locale semantics correctly, the ARIA Authoring Practices should mention that authors shall use locale-specific translations for "carousel" and "slide", and maybe even provide term suggestions for different languages.

Notice that the examples Auto-Rotating Image Carousel Example with Buttons for Slide Control and Auto-Rotating Image Carousel with Tabs for Slide Control Example also currently use the English-centric aria-roledescription carousel and slide without mentioning that locale-specific terms should be used.

@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force labels May 24, 2022
@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed carousel pattern should use localized "aria-roledescription"s for its elements.

The full IRC log of that discussion <MarkMcCarthy> TOPIC: carousel pattern should use localized "aria-roledescription"s for its elements
<jamesn> github: https://github.com//issues/2355
<MarkMcCarthy> jongunderson: is that just saying the documentation should make mention of being localized?
<MarkMcCarthy> Matt_King: isn't that the same as aria-label?
<MarkMcCarthy> jamesn: aria-labels are usually announced in the PAGE's language, but roles etc. are annouced in the USER's language
<MarkMcCarthy> jamesn: for roledescription, it can't be automagically translated. it's an ongoing problem with roledescription
<MarkMcCarthy> Matt_King: i always thought it was localized the same way the page was
<MarkMcCarthy> jamesn: yes AND it's the best we can do, really
<MarkMcCarthy> jongunderson: does the roledescription replace the original name?
<MarkMcCarthy> jamesn: it's supposed to
<MarkMcCarthy> jamesn: but depends on the implementation
<MarkMcCarthy> jamesn: many AT speak both languages
<MarkMcCarthy> s/languages/roledescription and name
<MarkMcCarthy> Matt_King: which kind of defeats the purpose
<MarkMcCarthy> Matt_King: should we do something different with roledescription vs label?
<MarkMcCarthy> jamesn: i think we're doing things right, but we could be clearer on dev's instructions
<MarkMcCarthy> Matt_King: so maybe a note about that somewhere?
<MarkMcCarthy> jamesn: yeah
<MarkMcCarthy> jongunderson: i can do that
<MarkMcCarthy> jongunderson: is there an issue changing index to examples in the menubar?
<MarkMcCarthy> jongunderson: seems like people are having some trouble finding examples
<MarkMcCarthy> jamesn: going through the patterns section is the way to go right?
<MarkMcCarthy> jongunderson: yeah, but when looking for certain things (like date picker) there's no pattern

mcking65 added a commit that referenced this issue Mar 21, 2023
…on uses the language of the page (pull #2358)

Fixes #2355 by:

Adding a note to the carousel examples that the `aria-roledescription` value uses the language of the page, similar to labeling of controls.

---------

Co-authored-by: Matt King <a11yThinker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force
Projects
None yet
4 participants